Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Hides paging controls in anomaly swim lane if only one page is available #163931

Merged
merged 1 commit into from Aug 15, 2023
Merged

[ML] Hides paging controls in anomaly swim lane if only one page is available #163931

merged 1 commit into from Aug 15, 2023

Conversation

darnautov
Copy link
Contributor

Summary

Resolves #151586

Hides pagination controls in the Anomaly Swim Lane if there are fewer results than pagination size.

image

@darnautov darnautov added release_note:enhancement :ml Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) v8.10.0 labels Aug 15, 2023
@darnautov darnautov self-assigned this Aug 15, 2023
@darnautov darnautov requested a review from a team as a code owner August 15, 2023 12:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

jgowdyelastic
jgowdyelastic approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@darnautov darnautov merged commit 39f2a25 into elastic:main Aug 15, 2023
31 checks passed
@darnautov darnautov deleted the ml-151586-hide-swim-lane-pagination branch August 15, 2023 17:09
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 15, 2023
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Aug 16, 2023
@darnautov @hop-dev
[ML] Hide paging controls in swim lane if only one page is available (e…
c2b6a58 
…lastic#163931)
@peteharverson peteharverson changed the title [ML] Hide paging controls in swim lane if only one page is available [ML] Hide paging controls in anomaly swim lane if only one page is available Aug 21, 2023
@peteharverson peteharverson changed the title [ML] Hide paging controls in anomaly swim lane if only one page is available [ML] Hides paging controls in anomaly swim lane if only one page is available Aug 22, 2023
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
@darnautov @bryce-b
[ML] Hide paging controls in swim lane if only one page is available (#…
8799323 
…163931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Hide paging controls in swim lane embeddable if only one page
5 participants
@darnautov @elasticmachine @kibana-ci @jgowdyelastic @kibanamachine