Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] expandable flyout - add investigate in timeline f… #165025

Merged

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Aug 28, 2023

Summary

This PR adds the missing interaction within the prevalence table in the expandable flyout left section.
The users can now click on the alert count and document count columns to view the results in timeline:

  • alert count clicks open timeline with the highlighted field key/value pair
  • document count clicks open timeline with the highlighted field key/value pair as well as event.kind !== signal
Screen.Recording.2023-08-29.at.12.52.04.AM.mov

Fixes #164974

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti force-pushed the expandable-flyout-prevalence-investigate-in-timeline branch 2 times, most recently from b45afbb to b1a1191 Compare August 28, 2023 17:34
@PhilippeOberti PhilippeOberti force-pushed the expandable-flyout-prevalence-investigate-in-timeline branch from 128f7ec to 9eb5367 Compare August 28, 2023 22:59
@PhilippeOberti PhilippeOberti marked this pull request as ready for review August 28, 2023 23:01
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner August 28, 2023 23:01
@PhilippeOberti PhilippeOberti enabled auto-merge (squash) August 28, 2023 23:03
…or alert count and document count prevalence details table columns
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 1a006a9 into main Aug 29, 2023
33 checks passed
@PhilippeOberti PhilippeOberti deleted the expandable-flyout-prevalence-investigate-in-timeline branch August 29, 2023 08:18
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 29, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
kibanamachine added a commit that referenced this pull request Aug 29, 2023
…eline f… (#165025) (#165064)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] expandable flyout - add investigate in timeline
f… (#165025)](#165025)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2023-08-29T08:18:40Z","message":"[Security
Solution] expandable flyout - add investigate in timeline f…
(#165025)","sha":"1a006a98f6eae85612baeb7e323341a2f8be3e87","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Threat
Hunting:Investigations","v8.10.0","v8.11.0"],"number":165025,"url":"https://github.com/elastic/kibana/pull/165025","mergeCommit":{"message":"[Security
Solution] expandable flyout - add investigate in timeline f…
(#165025)","sha":"1a006a98f6eae85612baeb7e323341a2f8be3e87"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165025","number":165025,"mergeCommit":{"message":"[Security
Solution] expandable flyout - add investigate in timeline f…
(#165025)","sha":"1a006a98f6eae85612baeb7e323341a2f8be3e87"}}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Misalignment on alert prevalence behaviour between old and new flyout
4 participants