Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Migrate Ace based EuiCodeEditor to Monaco based Code Editor #165951

Merged
merged 5 commits into from Sep 7, 2023
Merged

[APM] Migrate Ace based EuiCodeEditor to Monaco based Code Editor #165951

merged 5 commits into from Sep 7, 2023

Conversation

achyutjhunjhunwala
Copy link
Contributor

Summary

Closes #155841

Demo

Screen.Recording.2023-09-07.at.12.31.28.mov

DownSides

  • [KNOWN] Syntax Highlighting is gone
  • [KNOWN] Autocomplete is gone
  • [KNOWN] There is and was not a way to clear the query bar when in EQL mode. It throws error saying Empty Query cannot be fired

@achyutjhunjhunwala achyutjhunjhunwala added release_note:enhancement Team:APM All issues that need APM UI Team support labels Sep 7, 2023
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Sep 7, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner September 7, 2023 10:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

yngrdyn
yngrdyn approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 7, 2023 •
edited

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #1 / Prebuilt rules Alerts rules, prebuilt rules "before each" hook for "Loads prebuilt rules" "before each" hook for "Loads prebuilt rules"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "after all" hook in "Columns selection initialization and update"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "before all" hook in "Columns selection initialization and update"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1480 1472 -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB -41.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 37.0KB 36.9KB -87.0B
Unknown metric groups

async chunk count

id before after diff
apm 33 32 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit a105009 into elastic:main Sep 7, 2023
26 of 40 checks passed
@achyutjhunjhunwala achyutjhunjhunwala deleted the migrate-EuiCodeEditor-to-CodeEditor branch September 7, 2023 15:37
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 7, 2023
@achyutjhunjhunwala achyutjhunjhunwala changed the title Migrate Ace based EuiCodeEditor to Monaco based Code Editor [APM] Migrate Ace based EuiCodeEditor to Monaco based Code Editor Sep 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala mentioned this pull request Sep 8, 2023
Merged
achyutjhunjhunwala added a commit that referenced this pull request Sep 8, 2023
@achyutjhunjhunwala
[APM] Deleting old ace based EUI Code Editor (#166057)
d7714c6 
## Summary

In favour of this PR - #165951
As a post clean up task, removing the old Ace based EuiCodeEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Migrate from EuiCodeEditor to CodeEditor
6 participants
@achyutjhunjhunwala @elasticmachine @apmmachine @kibana-ci @yngrdyn @kibanamachine