Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Deleting old ace based EUI Code Editor #166057

Merged
merged 2 commits into from Sep 8, 2023
Merged

[APM] Deleting old ace based EUI Code Editor #166057

merged 2 commits into from Sep 8, 2023

Conversation

achyutjhunjhunwala
Copy link
Contributor

Summary

In favour of this PR - #165951
As a post clean up task, removing the old Ace based EuiCodeEditor

@achyutjhunjhunwala achyutjhunjhunwala added release_note:enhancement Team:APM All issues that need APM UI Team support labels Sep 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Sep 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner September 8, 2023 09:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala achyutjhunjhunwala added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Sep 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) September 8, 2023 09:53
@achyutjhunjhunwala achyutjhunjhunwala merged commit d7714c6 into elastic:main Sep 8, 2023
25 of 26 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the delete-old-ace-based-eui-editor branch September 8, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@achyutjhunjhunwala @elasticmachine @apmmachine @kibana-ci @sorenlouv @kibanamachine