Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Security Solution] Fix rule snooze toast copy #166030

Merged
merged 2 commits into from Sep 7, 2023
Merged

[RAM][Security Solution] Fix rule snooze toast copy #166030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dba3d3
[RAM][Security Solution] Update rule snooze toast copy
Zacqary Sep 7, 2023
e2d6787
Apply suggestions from code review
Zacqary Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ctions_ui/public/application/sections/rules_list/components/notify_badge/translations.tsx
View file
Open in desktop
Expand Up @@ -10,14 +10,14 @@ import { i18n } from '@kbn/i18n';
export const SNOOZE_SUCCESS_MESSAGE = i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListSnoozePanel.snoozeSuccess',
{
defaultMessage: 'Rule successfully snoozed',
defaultMessage: 'Rules notification successfully snoozed',
}
);

export const UNSNOOZE_SUCCESS_MESSAGE = i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListSnoozePanel.unsnoozeSuccess',
{
defaultMessage: 'Rule successfully unsnoozed',
defaultMessage: 'Rules notification successfully unsnoozed',
}
);

Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/security_solution_cypress/cypress/tasks/rule_snoozing.ts
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ export function snoozeRule(duration: SnoozeDuration): void {
}

export function expectSnoozeSuccessToast(): void {
cy.get(TOASTER).should('contain', 'Rule successfully snoozed');
cy.get(TOASTER).should('contain', 'Rules notification successfully snoozed');
}

export function expectSnoozeErrorToast(): void {
Expand Down Expand Up @@ -72,7 +72,7 @@ export function unsnoozeRule(): void {
}

export function expectUnsnoozeSuccessToast(): void {
cy.get(TOASTER).should('contain', 'Rule successfully unsnoozed');
cy.get(TOASTER).should('contain', 'Rules notification successfully unsnoozed');
}

export function expectRuleUnsnoozed(): void {
Expand Down