Fix EuiBottomBar in serverless #166840
Merged
Fix EuiBottomBar in serverless #166840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
added
the
release_note:skip
pgayvallet
reviewed
Sep 21, 2023
|
@elasticmachine merge upstream |
|
Can someone from @elastic/kibana-design review this as you are codeowners? thanks! |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…a into fix-bottom-bar-serverless
|
@elastic/kibana-design @elastic/appex-sharedux can we please have a review? |
sebelga
approved these changes
Oct 2, 2023
|
@ryankeairns @daveyholler @mdefazio Can we get someone's review here please? |
4 tasks
|
Depends on #167555 |
nchaulet
force-pushed
the
fix-bottom-bar-serverless
branch
from
bdf41d5
to
be9936a
Compare
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
MichaelMarcialis
approved these changes
Oct 4, 2023
kibanamachine
added
v8.12.0
backport:skip
semd
added a commit
that referenced
this pull request
Oct 6, 2023
## Summary The latest changes applied [here ](#166840) caused the `KibanaPageTemplate.BottomBar` to not work properly:  The `margin-left` should be applied only to `.euiBottomBar--fixed` instead of all `.euiBottomBar`, `--sticky` and `--static` are already positioned correctly to the relative parent, so no margin needs to be applied.
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
## Summary The latest changes applied [here ](elastic#166840) caused the `KibanaPageTemplate.BottomBar` to not work properly:  The `margin-left` should be applied only to `.euiBottomBar--fixed` instead of all `.euiBottomBar`, `--sticky` and `--static` are already positioned correctly to the relative parent, so no margin needs to be applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiBottomBar is broken in serverless because of the side nav, the width is not correct and is behind the side nav
For example in Fleet
Expected
Actual
That PR attempt to fix that, the solution is a little hacky with a css attr selector. It probably can be improved by adding a new class to the body when the nav is open in the
withSolutionNavcomponent, I can do the change if it's the direction we want to go