-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP] Log build number mismatch #170261
Merged
jloleysens
merged 10 commits into
elastic:main
from
jloleysens:add-log-about-version-mismatch
Nov 2, 2023
Merged
[HTTP] Log build number mismatch #170261
jloleysens
merged 10 commits into
elastic:main
from
jloleysens:add-log-about-version-mismatch
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Feature:http
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
release_note:skip
Skip the PR/issue when compiling release notes
v8.12.0
labels
Oct 31, 2023
jloleysens
force-pushed
the
add-log-about-version-mismatch
branch
from
November 1, 2023 12:30
952f3e0
to
314bf35
Compare
pgayvallet
approved these changes
Nov 2, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
This PR adds new behaviour to log a message when we are not enforcing strict client-server build number checks and see a different build number. ## How to test * Start Kibana * Set `server.versioned.strictClientVersionCheck: false` in `kibana.dev.yml` * Send a request that will return a bad response, in my case I sent `POST /api/files/files/defaultImage` with an empty body `{}` ## Assumptions * We only want to log when we are returning a bad response (>=400). It's possible that we miss events this way, but the assumption is that status codes >=400 are a strong indication that something is wrong, i.e. we don't care about mismatches when good responses happen * We want to treat this as a `WARN` level log * We will be able to track this in o11y using the `logger` context (like `kbn-build-number-mismatch`) ## Example ``` [2023-11-02T13:52:48.134+01:00][WARN ][http.kbn-build-number-mismatch] Client build (999999) is older than this Kibana server build (9007199254740991). The [400] error status in req id [29ad1f7c-056a-419b-9051-b45598aebd2c] may be due to client-server incompatibility! ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:http
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new behaviour to log a message when we are not enforcing strict client-server build number checks and see a different build number.
How to test
server.versioned.strictClientVersionCheck: false
inkibana.dev.yml
POST /api/files/files/defaultImage
with an empty body{}
Assumptions
WARN
level loglogger
context (likekbn-build-number-mismatch
)Example