-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] [8.11] Fix fleet_integration.ts API integration test flake #170510
Conversation
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @jpdjere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpdjere Is there any evidence, besides the green CI, that these changes reduce the flakiness?
@@ -12,7 +12,7 @@ import { | |||
getPrebuiltRulesAndTimelinesStatus, | |||
} from '../../utils'; | |||
import { deleteAllPrebuiltRuleAssets } from '../../utils/prebuilt_rules/delete_all_prebuilt_rule_assets'; | |||
import { installPrebuiltRulesFleetPackage } from '../../utils/prebuilt_rules/install_prebuilt_rules_fleet_package'; | |||
import { installPrebuiltRulesPackageViaFleetAPI } from '../../utils/prebuilt_rules/install_fleet_package_by_url'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think we should do some refactoring in main
in another PR. There are 2 files containing 4 functions for doing something with the fleet package with prebuilt rules.
No, actually: the issue has been extremely difficult to reproduce, it couldn't even be resurfaced with the flaky test runner. And Kibana Machine was reopening the ticket even when the test passed on a retry. The socket hangups/timeouts errors that were reported pointed to an issue on Fleet serverside (the endpoint timeing out, maybe), so switching to an individual package installation endpoint will hopefully give us a stabler test. There's no firm evidence, but I will keep an eye on the ticket to see if the flake is re-reported on 8.11. |
This PR didn't make it into the last BC of 8.11.0. Updating the labels. |
Fixes: #167056
See comment in ticket.
This is only the fix for 8.11.
Summary
security_detection_engine
package from the current Fleet bulk install packages endpoint to use the endpoint that installs a single package, in order to get to a more stable testFor maintainers