[8.11] [Security Solution ] Fix flake in bundled_prebuilt_rules_package/prerelease_packages.ts API Integration test (#169780)
#170119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…release_packages.ts` API Integration test (elastic#169780) Fixes: elastic#162192 ## Summary Removes flake by explicitly calling the Fleet endpoint to install the latest package, and doing assertions before actually installing the rules. Previously we were calling directly `installPrebuiltRules` without having explicitly installed the package before. The old installation endpoint would check that the package was installed before proceeding, but the new install method doesn't. So the explicit installation is required. ## Flaky test runs - ~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~ - ~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730 [CONTROL - NO CHANGES]~ - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773 [After refactor] (cherry picked from commit d1b7b7f)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
|
Closing in favour of: #170510 |
auto-merge was automatically disabled
November 3, 2023 22:30
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:bundled_prebuilt_rules_package/prerelease_packages.tsAPI Integration test (#169780)Questions ?
Please refer to the Backport tool documentation