Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Unified search] Auto expand dataview popovers based on the content #171411

Closed
wants to merge 6 commits into from

Conversation

mbondyra
Copy link
Contributor

Summary

Fixes partially two remaining tasks from #168753 - it stretches to maximum ~60 characters if the content needs it, but doesn't middle truncate yet (changes from eui are needed)

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:Unified search Unified search related tasks v8.12.0 labels Nov 16, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #76 / serverless observability UI Rules list should create an ES Query Rule and display it when consumer is observability
  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Timelines Toggle create timeline from plus icon Privileges: READ should not be able to create/update timeline should not be able to create/update timeline

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotationListing 196.9KB 196.9KB -7.0B
lens 1.4MB 1.4MB +81.0B
maps 2.9MB 2.9MB +125.0B
presentationUtil 82.0KB 82.1KB +153.0B
unifiedSearch 213.7KB 213.8KB +178.0B
total +530.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants