Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][CI] Indicate in the name of burning specs that they're only soft failing #172589

Conversation

gergoabraham
Copy link
Contributor

@gergoabraham gergoabraham commented Dec 5, 2023

Summary

Our burn specs jobs are soft failing, but kibana-bot says that the build is failed, and devs are confused.

Kibana OPS team is working on improving the status indication in comments of kibana-bot in PRs (here: https://github.com/elastic/kibana-buildkite-build-bot/pull/3).

Next to that, we could include in their name that they're soft failing, see sample image:

image image

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Dec 5, 2023
@gergoabraham gergoabraham self-assigned this Dec 5, 2023
@gergoabraham gergoabraham force-pushed the suggestion-for-including-soft-fail-indication-in-burning-specs-naming branch from c609597 to 67901ca Compare December 6, 2023 11:56
@gergoabraham gergoabraham changed the title [Defend Workflows][CI] Indicate in the name of burning specs that they're only soft failing [EDR Workflows][CI] Indicate in the name of burning specs that they're only soft failing Dec 6, 2023
@gergoabraham gergoabraham marked this pull request as ready for review December 6, 2023 12:31
@gergoabraham gergoabraham requested a review from a team as a code owner December 6, 2023 12:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@gergoabraham gergoabraham enabled auto-merge (squash) December 7, 2023 10:36
@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #90 / Serverless Common UI - Management Data View Management index pattern filter "before each" hook for "should set "conflict" filter when "View conflicts" button is pressed"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

@gergoabraham gergoabraham merged commit 71f6606 into elastic:main Dec 7, 2023
39 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 7, 2023
gergoabraham added a commit that referenced this pull request Dec 8, 2023
…they're only soft failing (#172671)

## Summary

Backport of #172589

Goal: emphasise in our job names that they're soft failing.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gergoabraham gergoabraham deleted the suggestion-for-including-soft-fail-indication-in-burning-specs-naming branch December 18, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants