Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): bump node into v20 #173461

Merged
merged 31 commits into from Jan 2, 2024
Merged

chore(NA): bump node into v20 #173461

merged 31 commits into from Jan 2, 2024

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 15, 2023

Closes #173334

This is a reattempt of doing what was planned on #162696 after solving the bottlenecks we discovered previously.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.13.0 labels Dec 15, 2023
@elastic elastic deleted a comment from kibana-ci Dec 16, 2023
@mistic mistic mentioned this pull request Dec 16, 2023
@elastic elastic deleted a comment from kibana-ci Dec 16, 2023
@elastic elastic deleted a comment from kibana-ci Dec 18, 2023
@elastic elastic deleted a comment from kibana-ci Dec 19, 2023
@elastic elastic deleted a comment from kibana-ci Dec 19, 2023
@jbudz jbudz removed the skip-ci label Jan 2, 2024
@jbudz jbudz added v7.17.17 and removed backport:skip This commit does not require backporting labels Jan 2, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 2, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / discover/group1 discover test query Change of links to styles and js #2, which has an empty time range should show matches when time range is expanded
  • [job] [logs] Jest Tests #3 / EditAssigneesFlyout calls onClose when pressing the cancel button
  • [job] [logs] Jest Tests #3 / EditAssigneesFlyout renders correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit c6f9d98 into elastic:main Jan 2, 2024
42 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2024
Closes elastic#173334

This is a reattempt of doing what was planned on
elastic#162696 after solving the
bottlenecks we discovered previously.

---------

Co-authored-by: Jonathan Budzenski <jon@elastic.co>
(cherry picked from commit c6f9d98)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Upgrade slack/webhook (#173933)
- Replace deprecated node-sass with sass #2 (#173942)
- Upgrade to Node.js 20 (#162696)
- [artifacts] Add CI retries (#130194)
- [artifacts] Publish (#129499)
- [artifacts] Merge docker context verification (#129399)
- [artifacts] Merge package testing with release artifacts (#129378)
8.11 Backport failed because of merge conflicts
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 173461

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit that referenced this pull request Jan 3, 2024
jloleysens added a commit that referenced this pull request Jan 4, 2024
* main: (4129 commits)
  [Logs Explorer] Change the default link for "Discover" in the serverless nav (#173420)
  [Fleet] fix unhandled error in agent details when components are missing (#174152)
  [Obs UX] Unskip transaction duration alerts test (#174069)
  [Fleet] Fix keep policies up to date after package install (#174093)
  [Profiling] Stack traces embeddable (#173905)
  [main] Sync bundled packages with Package Storage (#174115)
  [SLO Form] Refactor to use kibana data view component (#173513)
  [Obs UX] Unskip APM Service Inventory Journey (#173510)
  [Obs UX] Unskip preview_chart_error_count test (#173624)
  [api-docs] 2024-01-03 Daily api_docs build (#174142)
  Update babel runtime helpers (#171745)
  Handle content stream errors in report pre-deletion (#173792)
  [Cloud Posture] [Quick wins] Enable edit DataView on the Misconfigurations Findings Table (#173870)
  [ftr] abort retry on invalid webdriver session (#174092)
  Upgrade openai to 4.24.1 (#173934)
  chore(NA): bump node into v20 (#173461)
  [Security Solution][Endpoint] Fix index name pattern in SentinelOne dev. script (#174105)
  fix versions.json
  [Obs AI Assistant] Add guardrails (#174060)
  [ML] Transforms: Refactor validators and add unit tests. (#173736)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 4, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173461 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.17 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 20