Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BK] Migrate batch 1 (Artifact builds) #182582

Merged
merged 3 commits into from
May 13, 2024
Merged

[BK] Migrate batch 1 (Artifact builds) #182582

merged 3 commits into from
May 13, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented May 3, 2024

Summary

Migrates batch 1 - artifact builds. The upload aspect wasn't tested, because it's programmed only to run from main, and we didn't want to interfere with the ongoing releases. This can be tested after the merge.

Verification:

Originals:

Backports:

The backports don't need to have the pipeline resource definition files, however, we forked 8.14 off from main, where we already had the resources. I'll remove all the unnecessary resource defs from the legacy branches, once we finalize the state (simply to save a little inconvenience on future backports.)

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release Team:Operations Team label for Operations Team backport:skip This commit does not require backporting and removed backport:all-open Backport to all branches that could still receive a release labels May 3, 2024
@delanni delanni marked this pull request as ready for review May 7, 2024 08:57
@delanni delanni requested a review from a team as a code owner May 7, 2024 08:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member

jbudz commented May 7, 2024

@delanni
Copy link
Contributor Author

delanni commented May 7, 2024

Bootstrap times still look a little off to me, did we ever create an issue to track that down?

https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4261#018f4d90-e33d-44b7-b118-3bd0c6ac9875/194-250 https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88#018f4d92-b5ac-46aa-8aad-126810fa8bd8/185-248

There is an issue for it: https://github.com/elastic/kibana-operations/issues/94 although (until now) it wasn't explicitly specified on the issue what's the expected problem to solve.

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 13, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit d5362fd into main May 13, 2024
17 checks passed
@delanni delanni deleted the migrate-batch-1-artifacts branch May 13, 2024 14:06
delanni added a commit that referenced this pull request May 13, 2024
@delanni delanni added v7.17.22 backport:prev-MAJOR Backport to the previous major branch (7.x) and all later branches still in development and removed backport:skip This commit does not require backporting labels May 15, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- chore(NA): bump node into v20 (#173461)
- Upgrade to Node.js 20 (#162696)
- [artifacts] Add CI retries (#130194)
- [artifacts] Publish (#129499)
- [artifacts] Merge docker context verification (#129399)
- [artifacts] Merge package testing with release artifacts (#129378)
8.14 Cherrypick failed because the selected commit (d5362fd) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

node scripts/backport --pr 182582

Questions ?

Please refer to the Backport tool documentation

delanni added a commit to delanni/kibana that referenced this pull request May 15, 2024
## Summary
Migrates batch 1 - artifact builds. The upload aspect wasn't tested,
because it's programmed only to run from `main`, and we didn't want to
interfere with the ongoing releases. This can be tested after the merge.

Verification:
- [x] RREs tested locally
- [x] kibana / artifacts trigger
(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/87)
- [x] kibana / artifacts container image
(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/86)
- [x] kibana / artifacts snapshot
(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)
- [x] kibana / artifacts staging
(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)
- [x] 8.13 / 8.14 / 7.17 verification (only a few jobs need to work
here)

Originals:
- kibana / artifacts trigger
[kibana-artifacts-trigger.yml](https://buildkite.com/elastic/kibana-artifacts-trigger)
- kibana / artifacts container image
[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-container-image)
- kibana / artifacts snapshot
[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-snapshot)
- kibana / artifacts staging
[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-staging)

Backports:
 - elastic#182781
 - elastic#182780

The backports don't need to have the pipeline resource definition files,
however, we forked 8.14 off from main, where we already had the
resources. I'll remove all the unnecessary resource defs from the legacy
branches, once we finalize the state (simply to save a little
inconvenience on future backports.)

(cherry picked from commit d5362fd)

# Conflicts:
#	.buildkite/pipeline-resource-definitions/locations.yml
#	.buildkite/pipelines/artifacts.yml
#	.buildkite/pipelines/artifacts_container_image.yml
#	.buildkite/pipelines/artifacts_trigger.yml
@delanni
Copy link
Contributor Author

delanni commented May 15, 2024

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

delanni added a commit that referenced this pull request May 15, 2024
# Backport

This will backport the following commits from `main` to `7.17`:
- [[BK] Migrate batch 1 (Artifact builds)
(#182582)](#182582)

It's supposed to fix:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds?branch=7.17

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-05-13T14:06:55Z","message":"[BK]
Migrate batch 1 (Artifact builds) (#182582)\n\n## Summary\r\nMigrates
batch 1 - artifact builds. The upload aspect wasn't tested,\r\nbecause
it's programmed only to run from `main`, and we didn't want
to\r\ninterfere with the ongoing releases. This can be tested after the
merge.\r\n\r\nVerification:\r\n- [x] RREs tested locally\r\n- [x] kibana
/ artifacts
trigger\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/87)\r\n-
[x] kibana / artifacts container
image\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/86)\r\n-
[x] kibana / artifacts
snapshot\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] kibana / artifacts
staging\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] 8.13 / 8.14 / 7.17 verification (only a few jobs need to
work\r\nhere)\r\n\r\nOriginals:\r\n- kibana / artifacts
trigger\r\n[kibana-artifacts-trigger.yml](https://buildkite.com/elastic/kibana-artifacts-trigger)\r\n-
kibana / artifacts container
image\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-container-image)\r\n-
kibana / artifacts
snapshot\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-snapshot)\r\n-
kibana / artifacts
staging\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-staging)\r\n\r\nBackports:\r\n
- #182781 -
#182780 \r\nThe backports
don't need to have the pipeline resource definition files,\r\nhowever,
we forked 8.14 off from main, where we already had the\r\nresources.
I'll remove all the unnecessary resource defs from the
legacy\r\nbranches, once we finalize the state (simply to save a
little\r\ninconvenience on future
backports.)","sha":"d5362fdaf7da5dd60f26da2ce4c64313c5930317","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-MAJOR","v8.15.0","v7.17.22"],"number":182582,"url":"#182582
Migrate batch 1 (Artifact builds) (#182582)\n\n## Summary\r\nMigrates
batch 1 - artifact builds. The upload aspect wasn't tested,\r\nbecause
it's programmed only to run from `main`, and we didn't want
to\r\ninterfere with the ongoing releases. This can be tested after the
merge.\r\n\r\nVerification:\r\n- [x] RREs tested locally\r\n- [x] kibana
/ artifacts
trigger\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/87)\r\n-
[x] kibana / artifacts container
image\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/86)\r\n-
[x] kibana / artifacts
snapshot\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] kibana / artifacts
staging\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] 8.13 / 8.14 / 7.17 verification (only a few jobs need to
work\r\nhere)\r\n\r\nOriginals:\r\n- kibana / artifacts
trigger\r\n[kibana-artifacts-trigger.yml](https://buildkite.com/elastic/kibana-artifacts-trigger)\r\n-
kibana / artifacts container
image\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-container-image)\r\n-
kibana / artifacts
snapshot\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-snapshot)\r\n-
kibana / artifacts
staging\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-staging)\r\n\r\nBackports:\r\n
- #182781 -
#182780 \r\nThe backports
don't need to have the pipeline resource definition files,\r\nhowever,
we forked 8.14 off from main, where we already had the\r\nresources.
I'll remove all the unnecessary resource defs from the
legacy\r\nbranches, once we finalize the state (simply to save a
little\r\ninconvenience on future
backports.)","sha":"d5362fdaf7da5dd60f26da2ce4c64313c5930317"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182582
Migrate batch 1 (Artifact builds) (#182582)\n\n## Summary\r\nMigrates
batch 1 - artifact builds. The upload aspect wasn't tested,\r\nbecause
it's programmed only to run from `main`, and we didn't want
to\r\ninterfere with the ongoing releases. This can be tested after the
merge.\r\n\r\nVerification:\r\n- [x] RREs tested locally\r\n- [x] kibana
/ artifacts
trigger\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/87)\r\n-
[x] kibana / artifacts container
image\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/86)\r\n-
[x] kibana / artifacts
snapshot\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] kibana / artifacts
staging\r\n(https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/88)\r\n-
[x] 8.13 / 8.14 / 7.17 verification (only a few jobs need to
work\r\nhere)\r\n\r\nOriginals:\r\n- kibana / artifacts
trigger\r\n[kibana-artifacts-trigger.yml](https://buildkite.com/elastic/kibana-artifacts-trigger)\r\n-
kibana / artifacts container
image\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-container-image)\r\n-
kibana / artifacts
snapshot\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-snapshot)\r\n-
kibana / artifacts
staging\r\n[kibana-artifacts.yml](https://buildkite.com/elastic/kibana-artifacts-staging)\r\n\r\nBackports:\r\n
- #182781 -
#182780 \r\nThe backports
don't need to have the pipeline resource definition files,\r\nhowever,
we forked 8.14 off from main, where we already had the\r\nresources.
I'll remove all the unnecessary resource defs from the
legacy\r\nbranches, once we finalize the state (simply to save a
little\r\ninconvenience on future
backports.)","sha":"d5362fdaf7da5dd60f26da2ce4c64313c5930317"}},{"branch":"7.17","label":"v7.17.22","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-MAJOR Backport to the previous major branch (7.x) and all later branches still in development release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.22 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants