[Dataset quality] Introduce management fly out #173554

yngrdyn · 2023-12-18T17:27:42Z

This PR was originally opened by @mohamedhamed-ahmed, in a mistake was closed by me 😅 when trying to bring the most recent changes from main and resolve the conflicts.

related to #170441

📝 Summary

This PR introduces the dataset quality flyout and shows the first 2 sections in the flyout, dataset and integration details. The new Actions column is also added as part of this PR.

✅ Testing

Navigate to /app/observability-log-explorer/dataset-quality
The Actions column should be visible at the rightmost side of the table
Dataset Name column should now be clickable and opens the flyout
Clicking the Open in Logs Explorer or the Open Action column should navigate to the Log Explorer with having the correct dataset and namespace selected

apmmachine · 2023-12-18T17:27:58Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…gement-fly-out

yngrdyn · 2023-12-19T12:36:46Z

/oblt-deploy

…gement-fly-out

- Change `"Type"` to `"Name"`.

…gement-fly-out

Added data_streams/details route. Added data_streams/details route.

…fix'

…gement-fly-out

yngrdyn · 2024-01-03T19:03:48Z

@awahab07 I was checking the custom deployment and I got this behaviour (Opening the fly out clicking on dataset title)

is that the latest version? if it's the latest version in the code we might need to update it to the little arrow present in other parts of the products (even logs explorer)

yngrdyn · 2024-01-03T19:04:56Z

NOTICE.txt

@@ -1,5 +1,5 @@
 Kibana source code with Kibana X-Pack source code
-Copyright 2012-2023 Elasticsearch B.V.
+Copyright 2012-2024 Elasticsearch B.V.


yngrdyn · 2024-01-03T19:06:23Z

x-pack/plugins/dataset_quality/common/data_streams_stats/data_stream_details.ts

Since we are not doing anything custom within this constructor we can omit it and use directly DataStreamDetails type

I see the constructor expand as we add more information to the model in future.

x-pack/test/dataset_quality_api_integration/tests/data_streams/data_stream_details.spec.ts

x-pack/test/dataset_quality_api_integration/utils/data_stream.ts

x-pack/test/dataset_quality_api_integration/common/config.ts

…gement-fly-out

awahab07 · 2024-01-15T14:55:47Z

/oblt-deploy

yngrdyn · 2024-01-16T09:53:33Z

I noticed the space per row is big, probably because of the new way of opening the flyout

This is how a row looked like before the opening mechanism

could we reduce the space around? For example in Log explorer the space is minimum

x-pack/plugins/dataset_quality/common/api_types.ts

x-pack/plugins/dataset_quality/common/data_streams_stats/data_stream_details.ts

x-pack/plugins/dataset_quality/common/data_streams_stats/data_stream_stat.ts

yngrdyn · 2024-01-16T10:21:51Z

x-pack/plugins/dataset_quality/public/components/flyout/dataset_summary.tsx

+  const formattedLastActivity = dataFormatter.convert(dataStreamStat.lastActivity);
+  const formattedCreatedOn = dataStreamDetails.createdOn
+    ? dataFormatter.convert(dataStreamDetails.createdOn)
+    : '';


@isaclfreire if we don't have the Created on info should we just remove the row in the table?

Makes sense 👍

I didn't implement hiding the row yet. Will there be valid cases when Created on won't be available?

yes, an index without a backing index will not return a Created on date. This will most likely be true for data streams without data

x-pack/plugins/dataset_quality/public/hooks/use_dataset_quality_flyout.tsx

x-pack/plugins/dataset_quality/server/routes/data_streams/get_data_stream_details/index.ts

x-pack/plugins/dataset_quality/server/routes/data_streams/routes.ts

…gement-fly-out

- Adjusted table layout. - Added skeleton loader. - Refactored route, route params and associated types.

awahab07 · 2024-01-22T10:54:37Z

Updated table layout

Screen.Recording.2024-01-22.at.11.41.25.mov

yngrdyn

LGTM! Good job mate 🚀

mohamedhamed-ahmed

Thanks for putting the effort into this!! LGTM

kibana-ci · 2024-01-22T13:48:47Z

💚 Build Succeeded

Buildkite Build
Commit: 732509a

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`datasetQuality`	68	79	+11

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`datasetQuality`	33.6KB	40.2KB	+6.6KB

History

💔 Build #188439 failed b68e259
💚 Build #187471 succeeded 210c691
💚 Build #186197 succeeded 7704d3c
💔 Build #186182 failed a071ed8
💔 Build #186148 failed 02bfbe0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @awahab07 @mohamedhamed-ahmed

awahab07 · 2024-01-22T14:26:01Z

/oblt-deploy

awahab07 · 2024-01-22T14:26:27Z

/oblt-deploy-serverless

related to elastic#170441 ## 📝 Summary This PR introduces the dataset quality flyout and shows the first 2 sections in the flyout, dataset and integration details. The new Actions column is also added as part of this PR. --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co> Co-authored-by: Abdul Zahid <awahab07@yahoo.com>

elasticmachine · 2024-03-21T09:42:48Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

mohamedhamed-ahmed added 2 commits November 29, 2023 10:37

[Dataset quality] Implement Management Flyout

fafbc13

Bug Fix

1fbb4c8

yngrdyn requested a review from a team as a code owner December 18, 2023 17:27

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

5178402

…gement-fly-out

yngrdyn assigned awahab07 and mohamedhamed-ahmed Dec 19, 2023

yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2023

Merging latest version

795bf0a

yngrdyn force-pushed the 170441-introduce-management-fly-out branch from 1804ea1 to 795bf0a Compare December 19, 2023 09:35

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

786fdea

…gement-fly-out

yngrdyn linked an issue Dec 19, 2023 that may be closed by this pull request

[Dataset quality] Introduce management Fly-out #170441

Closed

awahab07 and others added 11 commits December 19, 2023 17:19

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

99153f2

…gement-fly-out

- Extract the list component out.

c3688ef

- Change `"Type"` to `"Name"`.

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

e16bd18

…gement-fly-out

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

c863e83

…gement-fly-out

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

8a36845

…gement-fly-out

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

16c23fd

…gement-fly-out

Added data_streams/details route.

8a961ab

Added data_streams/details route. Added data_streams/details route.

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

90a9cb7

…fix'

Fix type.

1ff810d

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

edc4b78

…gement-fly-out

[CI] Auto-commit changed files from 'node scripts/notice'

aaba951

yngrdyn commented Jan 3, 2024

View reviewed changes

x-pack/test/dataset_quality_api_integration/tests/data_streams/data_stream_details.spec.ts Show resolved Hide resolved

yngrdyn commented Jan 3, 2024

View reviewed changes

x-pack/test/dataset_quality_api_integration/utils/data_stream.ts Outdated Show resolved Hide resolved

yngrdyn commented Jan 3, 2024

View reviewed changes

x-pack/test/dataset_quality_api_integration/common/config.ts Outdated Show resolved Hide resolved

awahab07 added 4 commits January 5, 2024 20:57

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

7704d3c

…gement-fly-out

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

b40fd9a

…gement-fly-out

Merge remote-tracking branch 'origin/main' into 170441-introduce-mana…

06f9485

…gement-fly-out

Add expand/minimize button to open/close the flyout.

210c691