[Cloud Posture] [Quick wins] Enable edit DataView on the Misconfigurations Findings Table #173870
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import { render } from '@testing-library/react'; | ||
| import React from 'react'; | ||
| import { TestProvider } from '../../test/test_provider'; | ||
| import { CloudSecurityDataTable, CloudSecurityDataTableProps } from './cloud_security_data_table'; | ||
|
|
||
| const mockDataView = { | ||
| fields: { | ||
| getAll: () => [ | ||
| { id: 'field1', name: 'field1', customLabel: 'Label 1', visualizable: true }, | ||
| { id: 'field2', name: 'field2', customLabel: 'Label 2', visualizable: true }, | ||
| ], | ||
| getByName: (name: string) => ({ id: name }), | ||
| }, | ||
| getFieldByName: (name: string) => ({ id: name }), | ||
| getFormatterForField: (name: string) => ({ | ||
| convert: (value: string) => value, | ||
| }), | ||
| } as any; | ||
|
|
||
| const mockDefaultColumns = [{ id: 'field1' }, { id: 'field2' }]; | ||
|
|
||
| const mockCloudPostureDataTable = { | ||
| setUrlQuery: jest.fn(), | ||
| columnsLocalStorageKey: 'test', | ||
| filters: [], | ||
| onSort: jest.fn(), | ||
| sort: [], | ||
| query: {}, | ||
| queryError: undefined, | ||
| pageIndex: 0, | ||
| urlQuery: {}, | ||
| setTableOptions: jest.fn(), | ||
| handleUpdateQuery: jest.fn(), | ||
| pageSize: 10, | ||
| setPageSize: jest.fn(), | ||
| onChangeItemsPerPage: jest.fn(), | ||
| onChangePage: jest.fn(), | ||
| onResetFilters: jest.fn(), | ||
| getRowsFromPages: jest.fn(), | ||
| } as any; | ||
|
|
||
| const renderDataTable = (props: Partial<CloudSecurityDataTableProps> = {}) => { | ||
| const defaultProps: CloudSecurityDataTableProps = { | ||
| dataView: mockDataView, | ||
| isLoading: false, | ||
| defaultColumns: mockDefaultColumns, | ||
| rows: [], | ||
| total: 0, | ||
| flyoutComponent: () => <></>, | ||
| cloudPostureDataTable: mockCloudPostureDataTable, | ||
| loadMore: jest.fn(), | ||
| title: 'Test Table', | ||
| }; | ||
|
|
||
| return render( | ||
| <TestProvider> | ||
| <CloudSecurityDataTable {...defaultProps} {...props} /> | ||
| </TestProvider> | ||
| ); | ||
| }; | ||
|
|
||
| describe('CloudSecurityDataTable', () => { | ||
| it('renders loading state', () => { | ||
| const { getByTestId } = renderDataTable({ isLoading: true }); | ||
| expect(getByTestId('unifiedDataTableLoading')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders empty state when no rows are present', () => { | ||
| const { getByTestId } = renderDataTable(); | ||
| expect(getByTestId('csp:empty-state')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders data table with rows', async () => { | ||
| const mockRows = [ | ||
| { | ||
| id: '1', | ||
| raw: { | ||
| field1: 'Label 1', | ||
| field2: 'Label 2', | ||
| }, | ||
| flattened: { | ||
| field1: 'Label 1', | ||
| field2: 'Label 2', | ||
| }, | ||
| }, | ||
| ] as any; | ||
| const { getByTestId, getByText } = renderDataTable({ | ||
| rows: mockRows, | ||
| total: mockRows.length, | ||
| }); | ||
|
|
||
| expect(getByTestId('discoverDocTable')).toBeInTheDocument(); | ||
| expect(getByText('Label 1')).toBeInTheDocument(); | ||
| expect(getByText('Label 2')).toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,11 @@ export const Configurations = () => { | |
| path={findingsNavigation.findings_default.path} | ||
| render={() => ( | ||
| <TrackApplicationView viewId={findingsNavigation.findings_default.id}> | ||
| <LatestFindingsContainer | ||
| dataView={dataViewQuery.data!} | ||
|
There was a problem hiding this comment. Couple of general questions:
There was a problem hiding this comment.
IMO the downside is that we add a deep coupling with an object from the
that's a good suggestion, better than passing down a |
||
| dataViewRefetch={dataViewQuery.refetch} | ||
| dataViewIsRefetching={dataViewQuery.isRefetching} | ||
| /> | ||
| </TrackApplicationView> | ||
| )} | ||
| /> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw what
use perfected kibana data viewsmeans (in the TODO for this hook)? not directly related to this PR, but I'd add more context to this todo, as I for instance wouldn't know what to do with it