Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] [Tech Debt] refactor dataView into a context #174119

Closed
4 tasks
opauloh opened this issue Jan 2, 2024 · 1 comment · Fixed by #174413
Closed
4 tasks

[Cloud Posture] [Tech Debt] refactor dataView into a context #174119

opauloh opened this issue Jan 2, 2024 · 1 comment · Fixed by #174413
Assignees
@opauloh
Labels
Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture

Comments

@opauloh
Copy link
Contributor

opauloh commented Jan 2, 2024

Motivation

Follow up from this comment, this ticket aims to refactor how the dataView object is being passed on the configurations and vulnerabilities page into a context hook, so we can avoid passing down the dataView properties multiples times.

Definition of done

  • Create a hook for dataViewContext
  • Misconfigurations Page using the hook for dataView
  • Vulnerabilities Page using the hook for dataView
  • Unit tests

Related tasks/epics
@opauloh opauloh added technical debt Improvement of the software architecture and operational architecture Team:Cloud Security Cloud Security team related labels Jan 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh mentioned this issue Jan 2, 2024
Merged
@opauloh opauloh self-assigned this Jan 6, 2024
@opauloh opauloh linked a pull request Jan 6, 2024 that will close this issue
[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413
Merged
@opauloh opauloh mentioned this issue Jan 6, 2024
Merged
opauloh added a commit that referenced this issue Jan 13, 2024
@opauloh @kibanamachine
[Cloud Security] [Vulnerabilities] Add grouping capabilities (#174413)
c348925 
## Summary

It closes #165788 and #169050 and #174119

This PR adds the following changes to the Findings -> Vulnerabilities
page:

- Replaced the DataGrid component with the new CloudSecurityDataTable
component
- Added the new Grouping component with custom default renderers

It also introduced the following changes:
- Added context for DataView for easier reuse of the `dataView` methods.
- Refactored the Misconfigurations component to consume the `dataView`
context
- added FTR tests for the Vulnerabilities page
- dropped Flyout navigation support (will be readded in the future)


## Screenshots


![image](https://github.com/elastic/kibana/assets/19270322/c6cb7871-ce99-4c33-a615-142aaba63ec9)


![image](https://github.com/elastic/kibana/assets/19270322/ead3358f-7300-489b-b26d-5a37cc99e01d)

## Recording



https://github.com/elastic/kibana/assets/19270322/a47be0cf-2849-424d-b19a-d65cb6f502a8



https://github.com/elastic/kibana/assets/19270322/fa395488-7a22-476e-a50e-d0f0e28429e1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opauloh opauloh

Labels
Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cloud Security] [Vulnerabilities] Add grouping capabilities opauloh/kibana
2 participants
@elasticmachine @opauloh