Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Reporting plugin #174809

Merged
merged 8 commits into from
Jan 24, 2024
Merged

fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Reporting plugin #174809

merged 8 commits into from
Jan 24, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jan 13, 2024 •
edited
Loading

Summary

Closes #174798

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

For maintainers

@hainenber hainenber requested a review from a team as a code owner January 13, 2024 08:25
@hainenber hainenber requested a review from a team as a code owner January 13, 2024 09:09
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Jan 17, 2024
@tsullivan
Copy link
Member

buildkite build this

@tsullivan tsullivan self-requested a review January 17, 2024 22:43
@tsullivan
Copy link
Member

buildkite build this

tsullivan
tsullivan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you so much for handling this!

@eokoneyo
Copy link
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor

buildkite build this

@eokoneyo eokoneyo added the Feature:Reporting Reporting (PDF, CSV, ..) feature label Jan 24, 2024
@eokoneyo
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@eokoneyo
Copy link
Contributor

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 715 713 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 445.1KB 450.4KB +5.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
reporting 4 3 -1

Total ESLint disabled count

id before after diff
reporting 4 3 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Feature:Reporting Reporting (PDF, CSV, ..) feature labels Jan 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@tsullivan tsullivan assigned tsullivan and unassigned tsullivan Jan 24, 2024
@tsullivan tsullivan merged commit cd90773 into elastic:main Jan 24, 2024
42 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 24, 2024
@tsullivan tsullivan mentioned this pull request Jan 24, 2024
Closed
jloleysens added a commit that referenced this pull request Jan 25, 2024
@jloleysens
Merge branch 'main' into versioned-router-and-oas
f5151f6 
* main: (520 commits)
  Update Kibana code editor dependencies (#171720)
  [SLOs] Hide view in app in slo alerts table in slo details page (#175441)
  [api-docs] 2024-01-25 Daily api_docs build (#175502)
  [DOCS] Add buildkite links to doc preview comments (#175463)
  skip flaky suite (#175443)
  [Security Solution][Timeline] refactor timeline modal save timeline button (#175343)
  [RAM] Stack Management::Rules loses user selections when navigating back (#174954)
  [Security Solution][Timeline] refactor timeline modal attach to case button (#175163)
  Upgrade EUI to v92.1.1 (#174955)
  [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634)
  [Cloud Security] Rules Combo Box filters Custom component (#175175)
  skip flaky suite (#175407)
  [Security Solution][Timeline] refactor timeline modal open timeline button (#175335)
  [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348)
  [Console] disable access to embedded console without dev tools capability (#175321)
  fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809)
  [Security Solution] Data quality dashboard persistence (#173185)
  [RAM][Observability] Add alert fields table to Observability flyout (#174685)
  test: add missing await for connector table disappearance (#175430)
  [RAM][Maintenance Window] Fix maintenance window FE types and transforms  (#173888)
  ...
lcawl pushed a commit to lcawl/kibana that referenced this pull request Jan 26, 2024
@hainenber @tsullivan
@kibanamachine @lcawl
fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Re…
13caab8 
…porting plugin (elastic#174809)

## Summary
Closes elastic#174798 


### Checklist

Delete any items that are not applicable to this PR.



### Risk Matrix

Delete this section if it is not applicable to this PR.


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@hainenber @tsullivan
@kibanamachine @CoenWarmer
fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Re…
991ef71 
…porting plugin (elastic#174809)

## Summary
Closes elastic#174798 


### Checklist

Delete any items that are not applicable to this PR.



### Risk Matrix

Delete this section if it is not applicable to this PR.


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@hainenber @tsullivan
@kibanamachine @CoenWarmer
fix(x-pack/reporting): use FIPS-compliant ID generator uuidv4 in Re…
57cf883 
…porting plugin (elastic#174809)

## Summary
Closes elastic#174798 


### Checklist

Delete any items that are not applicable to this PR.



### Risk Matrix

Delete this section if it is not applicable to this PR.


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees

@hainenber hainenber

Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update library used to generate IDs in the Report constructor to be FIPS compliant
7 participants
@hainenber @tsullivan @eokoneyo @kibana-ci @elasticmachine @cnasikas @kibanamachine