test: add missing await for connector table disappearance #175430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
release_note:fix
release_note:skip
delanni
commented
Jan 24, 2024
x-pack/test_serverless/functional/page_objects/svl_search_connectors_page.ts
Outdated
Show resolved
Hide resolved
saarikabhasi
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
changes LGTM.
Quick question: is there a better way to test these FTR tests to avoid the failures like this in future?
Reason I am asking is, I did not see these errors when I was testing locally, with my PR CIs, and MKI tests. and I am worried if I have missed any aspect of testing here. Thanks in advance!
|
@saarikabhasi - the only thing I can think of is the flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner You can set up your proposed changes, then run several retries on the same case, to see if it still occasionally happens or is quite reliably stable. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
that referenced
this pull request
Jan 25, 2024
* main: (520 commits) Update Kibana code editor dependencies (#171720) [SLOs] Hide view in app in slo alerts table in slo details page (#175441) [api-docs] 2024-01-25 Daily api_docs build (#175502) [DOCS] Add buildkite links to doc preview comments (#175463) skip flaky suite (#175443) [Security Solution][Timeline] refactor timeline modal save timeline button (#175343) [RAM] Stack Management::Rules loses user selections when navigating back (#174954) [Security Solution][Timeline] refactor timeline modal attach to case button (#175163) Upgrade EUI to v92.1.1 (#174955) [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634) [Cloud Security] Rules Combo Box filters Custom component (#175175) skip flaky suite (#175407) [Security Solution][Timeline] refactor timeline modal open timeline button (#175335) [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348) [Console] disable access to embedded console without dev tools capability (#175321) fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809) [Security Solution] Data quality dashboard persistence (#173185) [RAM][Observability] Add alert fields table to Observability flyout (#174685) test: add missing await for connector table disappearance (#175430) [RAM][Maintenance Window] Fix maintenance window FE types and transforms (#173888) ...
lcawl
pushed a commit
to lcawl/kibana
that referenced
this pull request
Jan 26, 2024
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's been a few recent failures in this test:
https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd
https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637
I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the
Unhandled Promise rejection detected:kind of errors, since we'll now wait for the expression.cc: @saarikabhasi