[savedObjects/mappings] limit valid type names #17511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
💚 Build Succeeded |
rhoboat
reviewed
Apr 4, 2018
| const props = formatListAsProse(illegal); | ||
| const owner = pluginId ? `registered by plugin ${pluginId} ` : ''; | ||
| throw new Error( | ||
| `Property name${props.length > 1 ? 's' : ''} ${props} ${owner}are not allowed to start with an underscore (_)` |
There was a problem hiding this comment.
Is there a reason there's no space between ${owner} and are? Also same thing on line 38.
There was a problem hiding this comment.
Oh, lines 36 & 44 have the trailing space. Just feels wrong.
spalger
force-pushed
the
fix/saved-objects/type-limitations
branch
from
d4e7890
to
7df8404
Compare
💚 Build Succeeded |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Apr 9, 2018
spalger
added a commit
that referenced
this pull request
Apr 10, 2018
|
6.3/6.x: f04dcb0 |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17510
Limits the valid type names supported by the SavedObject mappings to ensure that users don't register type names that start with
_. This is done similarly to how we verify that saved object mappings between plugins don't conflict, by checking when attempting to merge the mappings together.Release note:
Starting in Kibana 6.3 the Saved Object API will use underscore-prefixed names for certain endpoints, so to disambiguate these endpoint names from the type parameter supported by some other Saved Object API endpoints, type names can no longer start with an underscore (_) character.