[savedObjects] add experimental filter capabilities #17513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
WIP
spalger
force-pushed
the
implement/saved-objects/experimental-filter
branch
from
fd29456
to
a1b39f6
Compare
💔 Build Failed |
3 tasks
spalger
force-pushed
the
implement/saved-objects/experimental-filter
branch
from
a1b39f6
to
8ae2587
Compare
spalger
force-pushed
the
implement/saved-objects/experimental-filter
branch
2 times, most recently
from
c05f9a5
to
9ceb0e2
Compare
💔 Build Failed |
|
Jenkins test this |
💚 Build Succeeded |
spalger
commented
Apr 3, 2018
| return {}; | ||
| } | ||
|
|
||
| const bool = {}; | ||
| const savedObjectTypes = type ? [type] : Object.keys(getRootProperties(mappings)); |
There was a problem hiding this comment.
Does this include type property?
There was a problem hiding this comment.
Turns out it did, so e5307b7
spalger
force-pushed
the
implement/saved-objects/experimental-filter
branch
from
e5307b7
to
77f259f
Compare
💚 Build Succeeded |
…objects/bulk-get-and-find
…objects/bulk-get-and-find
spalger
force-pushed
the
implement/saved-objects/experimental-filter
branch
from
b4f58e2
to
764a2e0
Compare
💔 Build Failed |
…ed-objects/experimental-filter
💚 Build Succeeded |
…ed-objects/experimental-filter
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17510
Based on #17512
WIP