[Ent Search] Connector client copy cleanup #176290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemthompo
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @leemthompo |
@sphilipse what was the nit? :) |
sphilipse
approved these changes
Feb 6, 2024
| @@ -145,7 +143,7 @@ | |||
| 'xpack.enterpriseSearch.content.indices.configurationConnector.researchConfiguration.serviceDocumentationLinkLabel': '{name} documentation', | |||
| 'xpack.enterpriseSearch.content.indices.configurationConnector.scheduleSync.description': 'Once your connectors are configured to your liking, don’t forget to set a recurring sync schedule to make sure your documents are indexed and relevant. You can also trigger a one-time sync without enabling a sync schedule.', | |||
| 'xpack.enterpriseSearch.content.indices.configurationConnector.steps.deployConnector.title': 'Deploy a connector', | |||
| 'xpack.enterpriseSearch.content.indices.configurationConnector.steps.enhance.title': 'Enhance your connector client', | |||
| 'xpack.enterpriseSearch.content.indices.configurationConnector.steps.enhance.title': 'Configure your connector client', | |||
There was a problem hiding this comment.
We generally don't want to manually adjust copy in these files outside of deleting unused lines. The new copy will be automatically picked up down the line.
There was a problem hiding this comment.
Aha! Yes I did that manually before remembering to use the cli tool
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague (cherry picked from commit 87a66f2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [[Ent Search] Connector client copy cleanup (#176290)](#176290) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-06T17:31:55Z","message":"[Ent Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in #173366 The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.13.0","v8.12.2"],"title":"[Ent Search] Connector client copy cleanup","number":176290,"url":"#176290 Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in #173366 The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"#176290 Search] Connector client copy cleanup (#176290)\n\nAdditional fixes missed in #173366 The deployment first paragraph was outdated and irrelevant to the user\r\nworkflow\r\n- Some of step headings were vague","sha":"87a66f24898d9d0ad20b357f62cdc9ea407ad27b"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
|
This PR didn't make it on time to the latest build candidate of v8.12.1. Updating the labels. |
jloleysens
added a commit
that referenced
this pull request
Feb 7, 2024
* main: (224 commits) [Http] Replace `buildNr` with `buildSha` in static asset paths (#175898) [Ops] Fix GCS bucket access for future buildkite agents (#174756) [api-docs] 2024-02-07 Daily api_docs build (#176362) skip flaky suite (#176002) skip failing es promotion suite (#176359) [Cloud Security] [Grouping] Add URL Params support to the grouping components (#175749) chore(NA): update versions after v8.12.2 bump (#176309) chore(NA): update versions after v7.17.19 bump (#176313) skip failing test suite (#176352) [SLO] Enable burn rate alert by default during creation via UI (#176317) [Fleet] Add the uptime capability to observability projects (#176285) [Security Solution][Endpoint] Fix Manifest Manger so that it works with large (>10k) (#174411) [ResponseOps] Alert creation delay based on user definition (#175851) [data views] Default field formatters based on field meta values (#174973) [Cloud Security]Detection Rules counter on Rules Flyout (#176041) [Security Solution] Data Quality Dashboard persistence (#175673) [Ent Search] Connector client copy cleanup (#176290) [ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. (#175556) [ML] Anomaly Detection: Fix `values-dots` colors (#176303) [Fleet] Logstash Output - being compliant to RFC-952 (#176298) ...
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Additional fixes missed in elastic#173366 - The deployment first paragraph was outdated and irrelevant to the user workflow - Some of step headings were vague
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fixes missed in #173366