Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security]Detection Rules counter on Rules Flyout #176041

Merged
merged 13 commits into from
Feb 6, 2024
Merged

[Cloud Security]Detection Rules counter on Rules Flyout #176041

merged 13 commits into from
Feb 6, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Feb 1, 2024 •
edited
Loading

Summary

This PR adds a Detection Rules Counter on Rules Flyout, users are also able to add Detection Rule on Flyout

Screen.Recording.2024-02-01.at.1.23.42.AM.mov

When Rule is disabled, the text 'Disabled' will be rendered instead of Detection Rule Counter

Screenshot 2024-02-01 at 8 09 04 PM

@animehart animehart linked an issue Feb 1, 2024 that may be closed by this pull request
[Cloud Security] Detection rules tracker in rule flyout #175966
Closed
@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

1 similar comment
@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart animehart marked this pull request as ready for review February 2, 2024 19:04
@animehart animehart requested a review from a team as a code owner February 2, 2024 19:04
@animehart animehart added v8.13.0 release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Feb 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added the backport:skip This commit does not require backporting label Feb 2, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 403 405 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 401.5KB 403.0KB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@animehart animehart merged commit a50f0ae into elastic:main Feb 6, 2024
17 checks passed
jloleysens added a commit that referenced this pull request Feb 7, 2024
@jloleysens
Merge branch 'main' into versioned-router-and-oas
32ba707 
* main: (224 commits)
  [Http] Replace `buildNr` with `buildSha` in static asset paths (#175898)
  [Ops] Fix GCS bucket access for future buildkite agents (#174756)
  [api-docs] 2024-02-07 Daily api_docs build (#176362)
  skip flaky suite (#176002)
  skip failing es promotion suite (#176359)
  [Cloud Security] [Grouping] Add URL Params support to the grouping components (#175749)
  chore(NA): update versions after v8.12.2 bump (#176309)
  chore(NA): update versions after v7.17.19 bump (#176313)
  skip failing test suite (#176352)
  [SLO] Enable burn rate alert by default during creation via UI (#176317)
  [Fleet] Add the uptime capability to observability projects (#176285)
  [Security Solution][Endpoint] Fix Manifest Manger so that it works with large (>10k) (#174411)
  [ResponseOps] Alert creation delay based on user definition (#175851)
  [data views] Default field formatters based on field meta values (#174973)
  [Cloud Security]Detection Rules counter on Rules Flyout (#176041)
  [Security Solution] Data Quality Dashboard persistence (#175673)
  [Ent Search] Connector client copy cleanup (#176290)
  [ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. (#175556)
  [ML] Anomaly Detection: Fix `values-dots` colors (#176303)
  [Fleet] Logstash Output - being compliant to RFC-952 (#176298)
  ...
maxcold
maxcold reviewed Feb 7, 2024
View reviewed changes
...d_security_posture/public/pages/configurations/utils/create_detection_rule_from_benchmark.ts
@@ -0,0 +1,103 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animehart @opauloh This file is almost identical to create_detection_rule_from_finding.ts. Let's avoid such repetition and think about how to abstract the logic. I can see that the only different thing is where we take the data from. In one case it's finding.rule.benchmark and in another, it's benchmarkRule. All the rest look the same. If that's the case, it should be very simple to abstract and just pass the benchmark object

fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
@animehart @fkanout
[Cloud Security]Detection Rules counter on Rules Flyout (elastic#176041)
0be7815 
## Summary

This PR adds a Detection Rules Counter on Rules Flyout, users are also
able to add Detection Rule on Flyout


https://github.com/elastic/kibana/assets/8703149/a000c1d5-3cec-4631-b255-745547e93c38

When Rule is disabled, the text 'Disabled' will be rendered instead of
Detection Rule Counter

<img width="1423" alt="Screenshot 2024-02-01 at 8 09 04 PM"
src="https://github.com/elastic/kibana/assets/8703149/aad119d4-75a3-4407-8155-fb68d7d06f38">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@animehart @CoenWarmer
[Cloud Security]Detection Rules counter on Rules Flyout (elastic#176041)
36d4657 
## Summary

This PR adds a Detection Rules Counter on Rules Flyout, users are also
able to add Detection Rule on Flyout


https://github.com/elastic/kibana/assets/8703149/a000c1d5-3cec-4631-b255-745547e93c38

When Rule is disabled, the text 'Disabled' will be rendered instead of
Detection Rule Counter

<img width="1423" alt="Screenshot 2024-02-01 at 8 09 04 PM"
src="https://github.com/elastic/kibana/assets/8703149/aad119d4-75a3-4407-8155-fb68d7d06f38">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@animehart @CoenWarmer
[Cloud Security]Detection Rules counter on Rules Flyout (elastic#176041)
f16322f 
## Summary

This PR adds a Detection Rules Counter on Rules Flyout, users are also
able to add Detection Rule on Flyout


https://github.com/elastic/kibana/assets/8703149/a000c1d5-3cec-4631-b255-745547e93c38

When Rule is disabled, the text 'Disabled' will be rendered instead of
Detection Rule Counter

<img width="1423" alt="Screenshot 2024-02-01 at 8 09 04 PM"
src="https://github.com/elastic/kibana/assets/8703149/aad119d4-75a3-4407-8155-fb68d7d06f38">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@animehart @fkanout
[Cloud Security]Detection Rules counter on Rules Flyout (elastic#176041)
6481c81 
## Summary

This PR adds a Detection Rules Counter on Rules Flyout, users are also
able to add Detection Rule on Flyout


https://github.com/elastic/kibana/assets/8703149/a000c1d5-3cec-4631-b255-745547e93c38

When Rule is disabled, the text 'Disabled' will be rendered instead of
Detection Rule Counter

<img width="1423" alt="Screenshot 2024-02-01 at 8 09 04 PM"
src="https://github.com/elastic/kibana/assets/8703149/aad119d4-75a3-4407-8155-fb68d7d06f38">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold left review comments

@opauloh opauloh opauloh approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Detection rules tracker in rule flyout
5 participants
@animehart @elasticmachine @kibana-ci @maxcold @opauloh