Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Add alert_delay alerting rule option for Stack and Observability rules #176941

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 14, 2024

Summary

Relates to #173009

This PR updates the openAPI specification such that the Stack and Observability rules include the new alert_delay property.

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.13.0 labels Feb 14, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl changed the title [OAS] Add alert_delay alerting rule option for Stack rules [OAS] Add alert_delay alerting rule option for Stack and Observability rules Feb 14, 2024
@lcawl lcawl marked this pull request as ready for review February 15, 2024 02:00
@lcawl lcawl requested a review from a team as a code owner February 15, 2024 02:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from doakalexi February 15, 2024 02:00
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl enabled auto-merge (squash) February 16, 2024 01:46
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 90dbc86 into elastic:main Feb 16, 2024
37 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 16, 2024
…vability rules (#176941) (#177106)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[OAS] Add alert_delay alerting rule option for Stack and
Observability rules
(#176941)](#176941)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-02-16T03:09:48Z","message":"[OAS]
Add alert_delay alerting rule option for Stack and Observability rules
(#176941)","sha":"90dbc86732e51be7311d2e5f3e11681b045f5ac5","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","v8.13.0","v8.14.0"],"title":"[OAS]
Add alert_delay alerting rule option for Stack and Observability
rules","number":176941,"url":"#176941
Add alert_delay alerting rule option for Stack and Observability rules
(#176941)","sha":"90dbc86732e51be7311d2e5f3e11681b045f5ac5"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#176941
Add alert_delay alerting rule option for Stack and Observability rules
(#176941)","sha":"90dbc86732e51be7311d2e5f3e11681b045f5ac5"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
cee-chen pushed a commit to cee-chen/kibana that referenced this pull request Feb 19, 2024
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Feb 19, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants