[Observability Solution][Maintenance] Move to Emotion CSS, enable Telemetry and i18n ESLint rules for all Obs plugins #177785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
CoenWarmer
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
changed the title
…ity-solution-cleanup
…Warmer/kibana into feat/observability-solution-cleanup
CoenWarmer
commented
Feb 26, 2024
| @@ -60,7 +60,11 @@ export const ListStatus = ({ | |||
| }} | |||
| /> | |||
| } | |||
| actions={[<EuiButton onClick={onRetry}>{noDataRetryLabel}</EuiButton>]} | |||
| actions={[ | |||
| <EuiButton data-test-subj="logsExplorerListStatusButton" onClick={onRetry}> | |||
There was a problem hiding this comment.
The Telemetry ESLint rule is configured to autofix, so the CI has added these.
There was a problem hiding this comment.
Suggested change
| <EuiButton data-test-subj="logsExplorerListStatusButton" onClick={onRetry}> | |
| <EuiButton data-test-subj="logsExplorerListStatusRetryButton" onClick={onRetry}> |
CoenWarmer
force-pushed
the
feat/observability-solution-cleanup
branch
from
2369e2a
to
50a0272
Compare
CoenWarmer
commented
Feb 26, 2024
| @@ -110,7 +110,12 @@ export const AlertsPopover = () => { | |||
| {state.isAddRuleFlyoutOpen && addRuleFlyout} | |||
| <EuiPopover | |||
| button={ | |||
| <EuiButtonEmpty onClick={togglePopover} iconType="arrowDown" iconSide="right"> | |||
| <EuiButtonEmpty | |||
| data-test-subj="observabilityLogsExplorerAlertsPopoverAlertsButton" | |||
There was a problem hiding this comment.
The Telemetry ESLint rule is configured to autofix, so the CI has added these.
CoenWarmer
commented
Feb 26, 2024
packages/kbn-optimizer/limits.yml
Outdated
| @@ -90,7 +90,7 @@ pageLoadAssetSize: | |||
| licensing: 29004 | |||
| links: 44490 | |||
| lists: 22900 | |||
| logsExplorer: 55000 | |||
| logsExplorer: 57000 | |||
There was a problem hiding this comment.
Bundle was going 1.2kb over the limit
jasonrhodes
approved these changes
Feb 27, 2024
jbudz
approved these changes
Feb 27, 2024
cauemarcondes
approved these changes
Mar 4, 2024
maciejforcone
approved these changes
Mar 5, 2024
tonyghiani
reviewed
Mar 5, 2024
..._solution/logs_explorer/public/components/flyout_detail/sub_components/highlight_section.tsx
Outdated
Show resolved
Hide resolved
…ponents/flyout_detail/sub_components/highlight_section.tsx Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
tonyghiani
approved these changes
Mar 5, 2024
ryankeairns
approved these changes
Mar 5, 2024
…ity-solution-cleanup
botelastic
bot
added
the
Team:obs-knowledge
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
miltonhultgren
approved these changes
Mar 14, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.14.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This does two things:
Why?
Move to Emotion CSS
There were four .scss files total in the 17 Observability plugins. Two of them were empty. The remaining two had one class each. By removing the two empty files and moving to Emotion, we can remove the lines pertaining to .scss files in the CODEOWNERS file.
Enabling Telemetry and i18n ESLint rules for all Observability apps
One of the reasons for consolidating Obs apps into one folder was to create a more consistent development experience across apps in the Observability org.
By changing the eslint rule config to enable the Telemetry and i18n ESLint rules on all
.tsandtsxfiles inobservability_solution, we enable the rule for 5 apps that did not have them enabled before and we ensure that the rule will immediately be enabled on new Observability applications at the moment of creation.Related PRs: