Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moving] Move Logs Shared folder into /x-pack/observability_solution #177735

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Feb 23, 2024

Summary

This PR is part of the initiative to consolidate Observability plugins into x-pack/plugins/observability_solution.

This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023.

Related PRs:

@CoenWarmer CoenWarmer requested review from a team as code owners February 23, 2024 15:58
@CoenWarmer CoenWarmer requested a review from a team February 23, 2024 15:58
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CoenWarmer added a commit that referenced this pull request Feb 24, 2024
…olution` (#177437)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](#177433)
- [x] [Move Data Quality](#177456)
- [x] [Move Exploratory
View](#177440)
- [ ] [Move Infra](#177443)
- [X] Move Logs Explorer
- [ ] [Move Logs Shared](#177735)
- [x] [Move Observability AI
Assistant](#177427)
- [ ] [Move Observability
App](#177437) <-- you are here
- [x] [Move Observability
Onboarding](#177458)
- [x] [Move Observability
Shared](#177463)
- [x] [Move Profiling](#177453)
- [x] [Move Synthetics](#177464) 
- [x] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / SyncAlertsToggle it shows the correct labels
  • [job] [logs] Jest Tests #14 / UserCommentPropertyActions renders the correct number of actions

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
…olution` (elastic#177437)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [ ] [Move Logs Shared](elastic#177735)
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437) <-- you are here
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…olution` (elastic#177437)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [ ] [Move Logs Shared](elastic#177735)
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437) <-- you are here
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@CoenWarmer CoenWarmer merged commit 31bc6c4 into elastic:main Mar 5, 2024
37 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 5, 2024
CoenWarmer added a commit that referenced this pull request Mar 14, 2024
…emetry and i18n ESLint rules for all Obs plugins (#177785)

## Summary

This does two things:

* Moves to Emotion CSS from .scss files
* Enables Telemetry and i18n ESLint rules for all Observability apps 

## Why?

**Move to Emotion CSS**
There were four .scss files total in the 17 Observability plugins. Two
of them were empty. The remaining two had one class each. By removing
the two empty files and moving to Emotion, we can remove the lines
pertaining to .scss files in the CODEOWNERS file.

**Enabling Telemetry and i18n ESLint rules for all Observability apps**
One of the reasons for consolidating Obs apps into one folder was to
create a more consistent development experience across apps in the
Observability org.

By changing the eslint rule config to enable the
[Telemetry](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-telemetry)
and
[i18n](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-i18n)
ESLint rules on all `.ts` and `tsx` files in `observability_solution`,
we enable the rule for 5 apps that did not have them enabled before and
we ensure that the rule will immediately be enabled on new Observability
applications at the moment of creation.

## Related PRs:
- [x] [Move APM ](#177433)
- [x] [Move Data Quality](#177456)
- [x] [Move Exploratory
View](#177440)
- [x] [Move Infra](#177443)
- [X] Move Logs Explorer
- [x] [Move Logs Shared](#177735)
- [x] [Move Observability AI
Assistant](#177427)
- [x] [Move Observability
App](#177437)
- [x] [Move Observability
Onboarding](#177458)
- [x] [Move Observability
Shared](#177463)
- [x] [Move Profiling](#177453)
- [x] [Move Synthetics](#177464) 
- [x] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants