-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolutions] Create Asset Criticality CSV upload page #179891
Conversation
/ci |
/ci |
/ci |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defend workflows review, lgtm 👍 left one question
x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to x-pack/plugins/security_solution/public/management/links.ts
looks good 👍
x-pack/plugins/security_solution/public/entity_analytics/api/api.ts
Outdated
Show resolved
Hide resolved
.../entity_analytics/components/asset_criticality_file_uploader/components/file_picker_step.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/entity_analytics/routes.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
...urity_solution/public/entity_analytics/components/asset_criticality_file_uploader/reducer.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a few small comments/thoughts
...ublic/entity_analytics/components/asset_criticality_file_uploader/components/result_step.tsx
Outdated
Show resolved
Hide resolved
...ublic/entity_analytics/components/asset_criticality_file_uploader/components/result_step.tsx
Outdated
Show resolved
Hide resolved
...c/entity_analytics/components/asset_criticality_file_uploader/components/validation_step.tsx
Outdated
Show resolved
Hide resolved
...y_solution/public/entity_analytics/components/asset_criticality_file_uploader/validations.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/resolver/view/panels/node_list.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigations changes! Mostly telemetry changes on our side. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DE changes LGTM
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @machadoum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI copy looks good
…nd permissions (#180771) ## Summary Related to #179891 * Display error message in case user doesn't have write access to asset criticality index ![Screenshot 2024-04-15 at 14 34 17](https://github.com/elastic/kibana/assets/1490444/9d92fe32-26cd-4c22-be0f-951f2a719c2b) * Display error message if the user navigates to the page when the user advanced (UI) setting is disabled ![Screenshot 2024-04-15 at 14 32 35](https://github.com/elastic/kibana/assets/1490444/1ef5a079-de19-40c7-b378-30f707483e99) * Remove links from menus and global search if advanced (UI) setting is disabled ![Screenshot 2024-04-15 at 14 40 35](https://github.com/elastic/kibana/assets/1490444/0342aeba-8a45-457e-958d-0e65bcc7cd80) Recoding of what happens when you don't refresh the page: https://github.com/elastic/kibana/assets/1490444/2b67403c-d58e-4d92-b12d-9f9de4c9a213 ### Expected behaviour: * After the setting is enabled, the user needs to refresh the browser to find the page * If users disable the setting on a different browser/tab and navigate to the page without refreshing, they will see an error message on the page. * If users disable the flag while the page is already rendered and try to upload the file, it will display an error on the last step. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
Create a new Asset Criticality page for updating asset criticality by file upload.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5665
Server side PR: #179930
asset.criticality.upload.recording.mov
The new page has three steps. You can access the page by going to Security -> Manage -> Asset Criticality.
File picker Step:
File validation step
Result step
Checklist
Delete any items that are not applicable to this PR.
a-docker)
How to test it?
What is not included?
Code owners files:
elastic/docs
elastic/security-defend-workflows
elastic/security-detection-engine
elastic/security-detections-response
elastic/security-engineering-productivity
elastic/security-threat-hunting
elastic/security-threat-hunting-investigations