[Fleet] agent monitoring http UI settings #180597
Conversation
|
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| enabled: z.boolean().default(false), | ||
| host: z.string().default('localhost'), | ||
| port: z.number().min(0).max(65353).default(6791), | ||
| 'buffer.enabled': z.boolean().default(false), |
There was a problem hiding this comment.
kept buffer.enabled as one field, it appears the same in agent config: https://github.com/elastic/elastic-agent/blob/main/elastic-agent.reference.yml#L163
the code doesn't support including more than one levels of nesting as of now.
juliaElastic
added
the
release_note:skip
| }, | ||
| { | ||
| name: 'agent.monitoring.http', | ||
| hidden: true, |
There was a problem hiding this comment.
Added a hidden flag to be able to hide a config without deleting from this file. This acts like a feature flag, so when a setting is ready to be rendered, just update hidden: false.
|
/ci |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
I added a |
kibanamachine
added
v8.14.0
backport:skip
Closes #158861 ## Summary Expose agent logging level in agent policy settings. The new setting is added via the new settings framework and will show up under "advanced settings". It's currently hidden until the agent supports it. ### Testing Enable the settings config: #180597 (comment) - Go to the agent policy settings form - Under advanced settings there is a new dropdown "Agent logging level". Choose a value and save the policy - The new value should be retained after saving - Go to the agent policies tab and select action "View policy" - The new field should be visible under `agent.logging.level` <details> <summary> Screenshots</summary>     </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Related to https://github.com/elastic/ingest-dev/issues/2471
Generate UI settings from an object type with nested fields.
Configured Agent monitoring http settings to show up on the UI to demo, it should be removed before merge as it's not yet supported by Agent.
The object field values are rendered as labels on the UI (e.g.
enabled).We could add description on the fields to render as tooltip/description.
The logic supports one level of object with base field types (number, string, boolean) for now. We could extend it with more levels if needed.
To verify:
Preview API requestto verify the request being sent to update the policyView policyto check how the new settings show up in full agent policy after savingAdded an (optional) description to fields to make it more human readable:
Checklist