[Eui] Warn Developer if Eui Provider is Missing #180819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
2 times, most recently
from
72b6c84
to
f584c9e
Compare
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
2 times, most recently
from
89242c3
to
21b4074
Compare
tsullivan
added a commit
that referenced
this pull request
Apr 30, 2024
## Summary Addresses extraneous errors discovered in #180819 --------- Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
21b4074
to
3350ac9
Compare
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…2005) ## Summary Addresses extraneous errors discovered in elastic#180819 --------- Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
5 times, most recently
from
cb8d8ed
to
4a18909
Compare
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
8 times, most recently
from
db3d70b
to
9fa5f44
Compare
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
7 times, most recently
from
6aa3c0b
to
f5e10c1
Compare
This was referenced May 20, 2024
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
6d15ab0
to
62c9e7b
Compare
tsullivan
added a commit
that referenced
this pull request
May 22, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree. ## Detailed description In #180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
62c9e7b
to
ab2948f
Compare
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
ab2948f
to
ccd0cd0
Compare
tsullivan
added a commit
that referenced
this pull request
May 24, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree. ## Detailed description In #180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
2 times, most recently
from
d12bdc3
to
4c67079
Compare
3 tasks
tsullivan
added a commit
that referenced
this pull request
May 25, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree: ## Detailed description In #180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. > [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/211859#018fa751-0f89-4253-bab7-b941897a15e1) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/211859/jobs/018fa751-0f89-4253-bab7-b941897a15e1/artifacts/018fa779-eab5-4d08-a948-17a1cd95826e) FTR Configs 33 / response-stream string stream example navigates to the example [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/211859#018fa77a-4796-429d-8165-9c8227307a0e) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/211859/jobs/018fa77a-4796-429d-8165-9c8227307a0e/artifacts/018fa788-2ed8-43ab-83c1-b781ae09b1cd) FTR Configs 33 / response-stream string stream example navigates to the example **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
May 29, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree. ## Detailed description In #180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
2a708f6
to
a177bd8
Compare
tsullivan
changed the title
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
2 times, most recently
from
40228e2
to
7df8d8b
Compare
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
3 tasks
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree. ## Detailed description In elastic#180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
Fixes needed for elastic#180819
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree. ## Detailed description In elastic#180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
## Summary Fixes needed for getting CI to pass when EUI throws an error if attempting to render a component without the EuiProvider in the render tree: ## Detailed description In elastic#180819, I will deliver a change that will cause EUI components to throw an error if the EuiProvider context is missing. This PR comes in as part of the final work to get all functional tests passing in an environment where EUI will throw the error. The tied to the ["Fix 'dark mode' inconsistencies in Kibana" Epic](elastic/kibana-team#805) has so far been in preparation for this. > [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/211859#018fa751-0f89-4253-bab7-b941897a15e1) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/211859/jobs/018fa751-0f89-4253-bab7-b941897a15e1/artifacts/018fa779-eab5-4d08-a948-17a1cd95826e) FTR Configs 33 / response-stream string stream example navigates to the example [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/211859#018fa77a-4796-429d-8165-9c8227307a0e) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/211859/jobs/018fa77a-4796-429d-8165-9c8227307a0e/artifacts/018fa788-2ed8-43ab-83c1-b781ae09b1cd) FTR Configs 33 / response-stream string stream example navigates to the example **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
May 31, 2024
…#184488) ## Summary Part of elastic/kibana-team#805 Addresses functional test failure found in #180819 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
tsullivan
force-pushed
the
clintandrewhall/dark-mode/detect-issues
branch
from
7df8d8b
to
4012bad
Compare
tsullivan
added
release_note:skip
|
replaced with #184608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced with #184608