[EuiProvider] Use KibanaRenderContextProvider in Console A11y Overlay #184488
Conversation
tsullivan
added
the
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
tsullivan
added
the
release_note:skip
| @@ -184,7 +184,7 @@ export class MonacoEditorActionsProvider { | |||
| public async sendRequests(dispatch: Dispatch<Actions>, context: ContextValue): Promise<void> { | |||
| const { | |||
| services: { notifications, trackUiMetric, http, settings, history, autocompleteInfo }, | |||
| startServices, | |||
There was a problem hiding this comment.
Some of the changes in this PR shuffle around the structure of services provided by useServicesContext, and makes the top-level directly include analytics, i18n, and theme rather than namespacing them under startServices. This will be consistent with most of the other changes I've made as part of #180819
| // The point of this element is for accessibility purposes, so ignore eslint error | ||
| // in this case | ||
| // | ||
| <> | ||
| <KibanaRenderContextProvider {...startServices}> |
There was a problem hiding this comment.
This is the change that directly addresses #180819
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @tsullivan |
There was a problem hiding this comment.
Thanks a lot for working on this fix, @tsullivan!
Verified locally that the a11y overlay still works the same in Console, migrated Console and Search profiler.
kibanamachine
added
v8.15.0
backport:skip
Summary
Part of https://github.com/elastic/kibana-team/issues/805
Addresses functional test failure found in #180819
Checklist
Delete any items that are not applicable to this PR.