Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Add callout for unconnected connectors #181166

Merged
merged 21 commits into from
May 22, 2024

Conversation

sphilipse
Copy link
Member

Summary

This moves a callout for connectors that haven't been connected. It also makes the service type change local instead of remote. This does two things:

  1. Make changing the service type not remove the callout (this happened because the API changes the status)
  2. Prevent conflicts between the connector's local config and the service type in the document (the connector itself should set the service type)

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 labels Apr 18, 2024
@sphilipse sphilipse requested a review from a team as a code owner April 18, 2024 14:51
@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@sphilipse sphilipse enabled auto-merge (squash) April 18, 2024 16:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
serverlessSearch 474.1KB 474.1KB -10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit e8c82e2 into elastic:main May 22, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants