[Lens] Save `valuesInLegend:true` as `legendStats:['value']` in preparation for legend statistics #181953

mbondyra · 2024-04-29T10:23:40Z

Summary

To the code owners,

This PR updates the saved object of Lens with the following changes: the property valuesInLegend: boolean is converted to the new property legendStats: ["currentAndLastValue"] (cartesian) or legendStats: ["value"](partition) to accommodate displaying additional legend statistics in the future. There are no user-facing changes introduced. I have updated all saved object shapes in the code to adhere to the new structure. While the old structure will continue to function properly, this update ensures cleaner code.

Fixes #181035 (phase 2). It's is a continuation of #180917.

In comparison to the phase 1, we've removed the conversion of legendStats to valuesInLegend which was initially added in the previous PR to ensure backward compatibility for serverless applications.

I won't merge till the end of the week as it has to be released separately from phase 1.

elasticmachine · 2024-04-29T10:24:29Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine · 2024-04-29T11:04:02Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

…o options from elastic-charts

…es (elastic#182001) Related to elastic#180677 closes elastic#181886 There's still a small difference on the CO2 values, but that's due to different formats returned by ES apis: ``` TopN Functions "self_annual_co2_tons": 0.0068555964801996295 Flamegraph "AnnualCO2TonsInclusive": [ 0.0069, ``` After: <img width="1765" alt="Screenshot 2024-04-29 at 16 34 57" src="https://github.com/elastic/kibana/assets/55978943/092a704f-69fe-4dd0-99d5-9ac9bce77188"> <img width="1788" alt="Screenshot 2024-04-29 at 16 35 03" src="https://github.com/elastic/kibana/assets/55978943/da4a1406-fad7-48de-81ac-e8aae64cba67">

## Summary The PR elastic#182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it.

## Summary As usual, the diff through the migration revealed some drifting between our assumed defaults and the defaults on the new infra. This PR re-adjusts the settings to how it was before the migration.

…paration to legend stats

cauemarcondes

Obs Services LGTM

machadoum

Entity Analytics changes LGTM!

nikitaindik

Hey @mbondyra! I have checked the Rule Management changes. LGTM.

nikitaindik · 2024-05-01T20:48:26Z

Actually, I just noticed one thing: in dashboard_rule_monitoring.json.

For "Executions by rule type" and "Executions by status" visualisations legendStats is equal to ["values"] (with an "s" at the end, not a singular "value").
Also, since it's an XY visualisation, shouldn't it be "currentAndLastValue"?

The dashboard works just fine, though. And it looks same as in main.

This branch

vs main

Is changing legendStats in JSONs supposed to have an effect of visualisations?

…a/kibana into lens/migrate_show_values_stage_2 # Conflicts: # x-pack/plugins/lens/public/visualizations/partition/visualization.test.ts # x-pack/plugins/lens/public/visualizations/xy/visualization.test.tsx # x-pack/plugins/security_solution/server/lib/dashboards/__mocks__/index.ts # x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/detection_engine_health/assets/dashboard_rule_monitoring.json

mbondyra · 2024-05-02T10:02:40Z

Hi @nikitaindik thanks for pointing it out. The legendStats: ['currentAndLastValue'] setting shows you the value of the last bucket if it exists or the current value in the legend when you hover over the series.

I fixed it already 🙏🏼

dej611

Tested locally with different scenarios ( a dashboard from 8.12 and one from the phase 1 state) and all worked fine 👍

kibana-ci · 2024-05-02T13:12:21Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 09dd2b5
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-181953-09dd2b564a99
Observability Deployment

Failed CI Steps

APM Cypress Tests #1

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.2MB	3.2MB	-81.0B
`lens`	1.4MB	1.4MB	-524.0B
`securitySolution`	13.7MB	13.7MB	+324.0B
total			-281.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5407	+5407
`total size`	-	9.1MB	+9.1MB

History

💔 Build #207439 failed 43a81e5
💚 Build #206991 succeeded 4369808

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ration for legend statistics (elastic#181953) ## Summary To the code owners, This PR updates the saved object of Lens with the following changes: the property `valuesInLegend: boolean` is converted to the new property `legendStats: ["currentAndLastValue"]` (cartesian) or `legendStats: ["value"]`(partition) to accommodate displaying additional legend statistics in the future. There are no user-facing changes introduced. I have updated all saved object shapes in the code to adhere to the new structure. While the old structure will continue to function properly, this update ensures cleaner code. Fixes elastic#181035 (phase 2). It's is a continuation of elastic#180917. In comparison to the phase 1, we've removed the conversion of legendStats to valuesInLegend which was initially added in the previous PR to ensure backward compatibility for serverless applications. <img width="807" alt="Screenshot 2024-04-25 at 10 51 50" src="https://github.com/elastic/kibana/assets/4283304/6c23d035-f64d-4fb1-96c6-d30392ae6752"> I won't merge till the end of the week as it has to be released separately from phase 1. --------- Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>

mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.15.0 labels Apr 29, 2024

mbondyra marked this pull request as ready for review April 29, 2024 10:24

mbondyra requested review from a team as code owners April 29, 2024 10:24

mbondyra requested a review from machadoum April 29, 2024 10:24

mbondyra requested a review from nikitaindik April 29, 2024 10:24

sebelga approved these changes Apr 29, 2024

View reviewed changes

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Apr 29, 2024

mbondyra changed the title ~~[Lens] Save valuesInLegend:true as legendStats:['values'] in preparation for legend statistics~~ [Lens] Save valuesInLegend:true as legendStats:['values'] in preparation for legend statistics Apr 29, 2024

mbondyra changed the title ~~[Lens] Save valuesInLegend:true as legendStats:['values'] in preparation for legend statistics~~ [Lens] Save valuesInLegend:true as legendStats:['value'] in preparation for legend statistics Apr 29, 2024

smith added the apm:review label Apr 29, 2024

mbondyra and others added 9 commits April 30, 2024 11:37

[Lens] correct legendStats option from 'values' to 'value' to align t…

f27cdf7

…o options from elastic-charts

change enum name

f7926c4

change enum name

8cd7dbb

divide the types

f28dd3e

[Fix] Add missing totalSeconds field (elastic#182093)

e79f435

## Summary The PR elastic#182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it.

[BK] Adjust settings to pre-migration state (elastic#182100)

8bb5ed0

## Summary As usual, the diff through the migration revealed some drifting between our assumed defaults and the defaults on the new infra. This PR re-adjusts the settings to how it was before the migration.

[Lens] save valuesInLegend: true as legendStats=['values'] in pre…

741dc0c

…paration to legend stats

no message

4369808

mbondyra force-pushed the lens/migrate_show_values_stage_2 branch from 00b0cb6 to 4369808 Compare April 30, 2024 15:10

cauemarcondes approved these changes Apr 30, 2024

View reviewed changes

machadoum approved these changes May 1, 2024

View reviewed changes

nikitaindik approved these changes May 1, 2024

View reviewed changes

mbondyra added 2 commits May 2, 2024 11:55

fix const

b5d8c09

Merge branch 'main' into lens/migrate_show_values_stage_2

09dd2b5

dej611 approved these changes May 2, 2024

View reviewed changes

mbondyra merged commit ab065ad into elastic:main May 3, 2024
39 checks passed

kibanamachine added the backport:skip This commit does not require backporting label May 3, 2024

mbondyra deleted the lens/migrate_show_values_stage_2 branch May 3, 2024 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Save `valuesInLegend:true` as `legendStats:['value']` in preparation for legend statistics #181953

[Lens] Save `valuesInLegend:true` as `legendStats:['value']` in preparation for legend statistics #181953

mbondyra commented Apr 29, 2024 •

edited

Loading

elasticmachine commented Apr 29, 2024

elasticmachine commented Apr 29, 2024

cauemarcondes left a comment

machadoum left a comment

nikitaindik left a comment

nikitaindik commented May 1, 2024

mbondyra commented May 2, 2024

dej611 left a comment

kibana-ci commented May 2, 2024 •

edited

Loading

[Lens] Save valuesInLegend:true as legendStats:['value'] in preparation for legend statistics #181953

[Lens] Save valuesInLegend:true as legendStats:['value'] in preparation for legend statistics #181953

Conversation

mbondyra commented Apr 29, 2024 • edited Loading

Summary

elasticmachine commented Apr 29, 2024

elasticmachine commented Apr 29, 2024

cauemarcondes left a comment

Choose a reason for hiding this comment

machadoum left a comment

Choose a reason for hiding this comment

nikitaindik left a comment

Choose a reason for hiding this comment

nikitaindik commented May 1, 2024

mbondyra commented May 2, 2024

dej611 left a comment

Choose a reason for hiding this comment

kibana-ci commented May 2, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Canvas Sharable Runtime

History

[Lens] Save `valuesInLegend:true` as `legendStats:['value']` in preparation for legend statistics #181953

[Lens] Save `valuesInLegend:true` as `legendStats:['value']` in preparation for legend statistics #181953

mbondyra commented Apr 29, 2024 •

edited

Loading

kibana-ci commented May 2, 2024 •

edited

Loading