Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14] [Security Solution] Handle invalid savedSearchId (#182937) #183059

Merged
merged 1 commit into from
May 9, 2024
Merged

[8.14] [Security Solution] Handle invalid savedSearchId (#182937) #183059

merged 1 commit into from
May 9, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

@logeekal
[Security Solution] Handle invalid savedSearchId (elastic#182937)
e82bd97 
## Summary

Handles elastic#182823

This PR resolves the issue where user opens a timeline with a
`savedSearchId` which no longer exists.

## Desk Testing Guide

1. Create an `Untitled Timeline` and add `ESQL` query and save the
timeline.
2. Make sure `Saved Objects` in Stack Management contains a new saved
object. with name - `Saved search for timeline -
<name_of_timeline_above>`.
3. Export the above created timeline as `ndjson` as shown below.
![Screenshot 2024-05-08 at 14 26
21](https://github.com/elastic/kibana/assets/7485038/cc134d53-7d07-40d9-8ee8-7e4e7a0c2cc9)
5. Delete the above created timeline
6. Make sure that corresponding saved objects is also deleted in `Saved
Objects` in Stack Management.
7. `Import` the timeline export in Step 3 on the Timelines Page.
8. Once imported.. Navigate to ESQL tab and save a arbitrary query.
9. Save the timeline... Switch to another timeline and then back.
10. The query you saved should be restored.

---------

Co-authored-by: Jan Monschke <janmonschke@fastmail.com>
(cherry picked from commit 02a22fd)
@kibanamachine kibanamachine enabled auto-merge (squash) May 9, 2024 15:49
@kibanamachine kibanamachine mentioned this pull request May 9, 2024
Merged
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / maps app Add layer panel "before all" hook for "should show unsaved layer in layer TOC"
  • [job] [logs] FTR Configs #4 / maps app embeddable maps add-to-dashboard save flow should allow new map be added by reference to a new dashboard
  • [job] [logs] FTR Configs #8 / Saved query management Feature controls Security: App vs Global privilege maps read-only privileges with disabled savedQueryManagement.saveQuery privilege "before all" hook for "shows read-only badge"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.2MB 15.2MB +222.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 514 515 +1

Total ESLint disabled count

id before after diff
securitySolution 591 592 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

@kibanamachine kibanamachine merged commit f3de2e9 into elastic:8.14 May 9, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@logeekal logeekal

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kibanamachine @kibana-ci @logeekal