Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Add new RCF use_document_level_security in Salesforce native configs #183600

Merged
merged 2 commits into from
May 16, 2024
Merged

[Search] Add new RCF use_document_level_security in Salesforce native configs #183600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ddf00
[Search] Add new RCF `use_document_level_security` in Salesforce nati…
moxarth-elastic May 16, 2024
41c40b3
update translation key
moxarth-elastic May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion packages/kbn-search-connectors/types/native_connectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4023,13 +4023,32 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
validations: [],
value: '',
},
use_document_level_security: {
default_value: null,
depends_on: [],
display: DisplayType.TOGGLE,
label: ENABLE_DOCUMENT_LEVEL_SECURITY_LABEL,
options: [],
order: 4,
required: true,
sensitive: false,
tooltip: getEnableDocumentLevelSecurityTooltip(
i18n.translate('searchConnectors.content.nativeConnectors.salesforce.useDocumentLevelSecurity.tooltip', {
defaultMessage: 'Salesforce',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the const USE_TEXT_EXTRACTION_SERVICE_TOOLTIP instead of creating a new translation string here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm just blind, I see it's a func. Nevermind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, the translation key should be different:

searchConnectors.nativeConnectors.salesforce.name

})
),
type: FieldType.BOOLEAN,
ui_restrictions: [],
validations: [],
value: false,
},
use_text_extraction_service: {
default_value: null,
depends_on: [],
display: DisplayType.TOGGLE,
label: USE_TEXT_EXTRACTION_SERVICE_LABEL,
options: [],
order: 4,
order: 5,
required: true,
sensitive: false,
tooltip: USE_TEXT_EXTRACTION_SERVICE_TOOLTIP,
Expand Down