Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip ES|QL Inspector tests #183894

Merged
merged 6 commits into from
May 23, 2024
Merged

[Discover] Unskip ES|QL Inspector tests #183894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
103ff95
[Discover] Unskip ES|QL Inspector tests
jughosta May 21, 2024
461aaf8
[Discover] Actually unskip
jughosta May 21, 2024
58c0225
[Discover] Update test
jughosta May 21, 2024
b4bc9d9
[Discover] Update test
jughosta May 22, 2024
fe9d5cf
[Discover] Update flaky test
jughosta May 22, 2024
4867262
Merge branch 'main' into 183847-unskip-esql-test
jughosta May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions test/functional/apps/discover/group4/_esql_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,21 +257,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/183847
describe.skip('inspector', () => {
describe('inspector', () => {
beforeEach(async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
});

it('shows Discover and Lens requests in Inspector', async () => {
await PageObjects.discover.selectTextBaseLang();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
await inspector.open();
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
let retries = 0;
await retry.try(async () => {
if (retries > 0) {
await inspector.close();
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
}
await inspector.open();
retries = retries + 1;
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
});
});
});

Expand Down
20 changes: 16 additions & 4 deletions x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,16 +261,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
beforeEach(async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
});

it('shows Discover and Lens requests in Inspector', async () => {
await PageObjects.discover.selectTextBaseLang();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
await inspector.open();
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
let retries = 0;
await retry.try(async () => {
if (retries > 0) {
await inspector.close();
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
}
await inspector.open();
retries = retries + 1;
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
});
});
});

Expand Down