Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip ES|QL Inspector tests #183894

Merged
merged 6 commits into from
May 23, 2024
Merged

[Discover] Unskip ES|QL Inspector tests #183894

merged 6 commits into from
May 23, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented May 21, 2024 •
edited by kibanamachine
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels May 21, 2024
@jughosta jughosta self-assigned this May 21, 2024
@kibanamachine

This comment was marked as outdated.

Sign in to view
@jughosta jughosta marked this pull request as ready for review May 21, 2024 10:00
@jughosta jughosta requested a review from a team as a code owner May 21, 2024 10:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

davismcphee
davismcphee reviewed May 21, 2024
View reviewed changes
test/functional/apps/discover/group4/_esql_view.ts Outdated
@@ -257,7 +257,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/183847
describe.skip('inspector', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flaky comment was removed, but it looks like the tests are still skipped in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️

@kibanamachine

This comment was marked as outdated.

Sign in to view
@jughosta jughosta marked this pull request as draft May 21, 2024 20:21
@kibanamachine

This comment was marked as outdated.

Sign in to view
@kibanamachine

This comment was marked as outdated.

Sign in to view
@jughosta
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6070

[✅] test/functional/apps/discover/group4/config.ts: 25/25 tests passed.

see run history

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review May 22, 2024 13:11
davismcphee
davismcphee approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it!

@jughosta jughosta merged commit d0d6075 into elastic:main May 23, 2024
17 checks passed
@jughosta jughosta deleted the 183847-unskip-esql-test branch May 23, 2024 06:40
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.14 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.14:
- [UII] Add back fleet_server.inactive to fleet_server.unenrolled to fleet usage telemetry (#184056)
- [DOCS] Adds the 8.14.0 release notes (#183914)
- [HTTP] Make alerting APIs public (#183945)

Manual backport

To create the backport manually run:

node scripts/backport --pr 183894

Questions ?

Please refer to the Backport tool documentation

@jughosta jughosta mentioned this pull request May 23, 2024
Merged
@jughosta
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jughosta added a commit to jughosta/kibana that referenced this pull request May 23, 2024
@jughosta
[Discover] Unskip ES|QL Inspector tests (elastic#183894)
5f01433 
- Closes elastic#183847

(cherry picked from commit d0d6075)

# Conflicts:
#	x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 24, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
@jughosta @rshen91
[Discover] Unskip ES|QL Inspector tests (elastic#183894)
544aa2c 
- Closes elastic#183847
jughosta added a commit that referenced this pull request May 30, 2024
@jughosta @davismcphee
[8.14] [Discover] Unskip ES|QL Inspector tests (#183894) (#184086)
04bbfc3 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Discover] Unskip ES|QL Inspector tests
(#183894)](#183894)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-05-23T06:40:34Z","message":"[Discover]
Unskip ES|QL Inspector tests (#183894)\n\n- Closes
#183847
Unskip ES|QL Inspector tests (#183894)\n\n- Closes
#183847
Unskip ES|QL Inspector tests (#183894)\n\n- Closes
#183847"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
@kibanamachine kibanamachine added v8.14.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 30, 2024
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @elasticmachine @kibana-ci @davismcphee