[Custom threshold][Logs Explorer] Fix the issue with saving default prefilled filters in the custom threshold rule on the Logs Explorer page #183900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
bug
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@thomheymann I saw you were adding a functional test in this PR. Did you also work on adding a functional test to create a custom threshold rule with prefilled filters? If yes, was there an issue with adding it? Maybe I can help with fixing it since having such a test would be very useful. |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
fkanout
reviewed
May 22, 2024
There was a problem hiding this comment.
@maryam-saeidi, when I select All logs and then create a rule, I see no data in the rule creation form, while there is data in the Log Explorer. 🤔
fkanout
reviewed
May 22, 2024
Yes, it is intentional, the logs explorer team didn't add such a logic. |
fkanout
approved these changes
May 22, 2024
There was a problem hiding this comment.
I approve the PR to unblock you @maryam-saeidi, and leave it to you handle the issue I mentioned in this one or create a different one.
Thanks for creating a ticket for it. I saw it once, but when I ran my Kibana server again, I wasn't able to reproduce it. I also checked edge-lite, and it worked fine there. I'll go ahead and merge this PR, and we can check the other issue separately. |
💚 Build Succeeded
Metrics [docs]Async chunks
Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 23, 2024
…filters in the custom threshold rule on the Logs Explorer page (elastic#183900) Fixes elastic#183710 ## Summary This PR fixes the issue of saving prefilled filters in the custom threshold rule by using `getSearchConfiguration` every time the serachConfiguration is saved in rule parameters. Now, `getSearchConfiguration` does two things: 1. Ensure the query has the correct type (`Qurey`), or it will be set as the default query. 2. Adjust filters by removing `$state` and only keeping `meta` and `query` Also, I adjusted the related type to exclude `$state`. ### How to test https://github.com/elastic/kibana/assets/12370520/9d69e601-d021-4ae3-8baf-88286d3716fe (cherry picked from commit 4ccd47d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 23, 2024
…filled filters in the custom threshold rule on the Logs Explorer page (#183900) (#184087) # Backport This will backport the following commits from `main` to `8.14`: - [[Custom threshold][Logs Explorer] Fix an issue with saving prefilled filters in the custom threshold rule on the Logs Explorer page (#183900)](#183900) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-05-23T07:16:07Z","message":"[Custom threshold][Logs Explorer] Fix an issue with saving prefilled filters in the custom threshold rule on the Logs Explorer page (#183900)\n\nFixes #183710\r\n\r\n## Summary\r\n\r\nThis PR fixes the issue of saving prefilled filters in the custom\r\nthreshold rule by using `getSearchConfiguration` every time the\r\nserachConfiguration is saved in rule parameters. Now,\r\n`getSearchConfiguration` does two things:\r\n1. Ensure the query has the correct type (`Qurey`), or it will be set as\r\nthe default query.\r\n2. Adjust filters by removing `$state` and only keeping `meta` and\r\n`query`\r\n\r\nAlso, I adjusted the related type to exclude `$state`.\r\n\r\n### How to test\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12370520/9d69e601-d021-4ae3-8baf-88286d3716fe","sha":"4ccd47d90e7b812d0d405cdd906a8b775757c1a4","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.15.0"],"title":"[Custom threshold][Logs Explorer] Fix an issue with saving prefilled filters in the custom threshold rule on the Logs Explorer page","number":183900,"url":"#183900 threshold][Logs Explorer] Fix an issue with saving prefilled filters in the custom threshold rule on the Logs Explorer page (#183900)\n\nFixes #183710\r\n\r\n## Summary\r\n\r\nThis PR fixes the issue of saving prefilled filters in the custom\r\nthreshold rule by using `getSearchConfiguration` every time the\r\nserachConfiguration is saved in rule parameters. Now,\r\n`getSearchConfiguration` does two things:\r\n1. Ensure the query has the correct type (`Qurey`), or it will be set as\r\nthe default query.\r\n2. Adjust filters by removing `$state` and only keeping `meta` and\r\n`query`\r\n\r\nAlso, I adjusted the related type to exclude `$state`.\r\n\r\n### How to test\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12370520/9d69e601-d021-4ae3-8baf-88286d3716fe","sha":"4ccd47d90e7b812d0d405cdd906a8b775757c1a4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183900 threshold][Logs Explorer] Fix an issue with saving prefilled filters in the custom threshold rule on the Logs Explorer page (#183900)\n\nFixes #183710\r\n\r\n## Summary\r\n\r\nThis PR fixes the issue of saving prefilled filters in the custom\r\nthreshold rule by using `getSearchConfiguration` every time the\r\nserachConfiguration is saved in rule parameters. Now,\r\n`getSearchConfiguration` does two things:\r\n1. Ensure the query has the correct type (`Qurey`), or it will be set as\r\nthe default query.\r\n2. Adjust filters by removing `$state` and only keeping `meta` and\r\n`query`\r\n\r\nAlso, I adjusted the related type to exclude `$state`.\r\n\r\n### How to test\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12370520/9d69e601-d021-4ae3-8baf-88286d3716fe","sha":"4ccd47d90e7b812d0d405cdd906a8b775757c1a4"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
…filters in the custom threshold rule on the Logs Explorer page (elastic#183900) Fixes elastic#183710 ## Summary This PR fixes the issue of saving prefilled filters in the custom threshold rule by using `getSearchConfiguration` every time the serachConfiguration is saved in rule parameters. Now, `getSearchConfiguration` does two things: 1. Ensure the query has the correct type (`Qurey`), or it will be set as the default query. 2. Adjust filters by removing `$state` and only keeping `meta` and `query` Also, I adjusted the related type to exclude `$state`. ### How to test https://github.com/elastic/kibana/assets/12370520/9d69e601-d021-4ae3-8baf-88286d3716fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183710
Summary
This PR fixes the issue of saving prefilled filters in the custom threshold rule by using
getSearchConfigurationevery time the serachConfiguration is saved in rule parameters. Now,getSearchConfigurationdoes two things:Qurey), or it will be set as the default query.$stateand only keepingmetaandqueryAlso, I adjusted the related type to exclude
$state.How to test
Screen.Recording.2024-05-22.at.18.mp4