Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook][i18n] initialize i18n with english locale #185033

Merged
merged 4 commits into from
Jun 7, 2024
Merged

[Storybook][i18n] initialize i18n with english locale #185033

merged 4 commits into from
Jun 7, 2024

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jun 7, 2024

Summary

We added a check to ensure that i18n is initialized on the browser before any javascript code uses i18n. We need to do the same in the storybook so it works properly.

To summarize in a couple of pictures 😄

Before PR:
image

After PR:

image

cc @petrklapka

@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes 8.16 candidate labels Jun 7, 2024
@Bamieh Bamieh requested a review from a team as a code owner June 7, 2024 16:23
PhilippeOberti
PhilippeOberti approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for 2 plugin Storybook (Security Solution and Threat Intelligence) and 1 package Storybook (kbn-expandable-flyout) and they all work now!
Thanks for fixing this!

@Bamieh Bamieh enabled auto-merge (squash) June 7, 2024 16:52
@PhilippeOberti PhilippeOberti mentioned this pull request Jun 7, 2024
Merged
@Bamieh
Copy link
Member Author

Bamieh commented Jun 7, 2024

@elasticmachine merge upstream

@Bamieh Bamieh merged commit 75d6815 into elastic:main Jun 7, 2024
20 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 7, 2024
@Bamieh Bamieh deleted the i18n_fix_storybook branch June 7, 2024 20:13
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Jun 13, 2024
@Bamieh @eokoneyo
[Storybook][i18n] initialize i18n with english locale (elastic#185033)
18b48f8 
## Summary

We added a check to ensure that `i18n` is initialized on the browser
before any javascript code uses `i18n`. We need to do the same in the
storybook so it works properly.

To summarize in a couple of pictures 😄 

**Before PR:**

![image](https://github.com/elastic/kibana/assets/6191849/3a598dd9-963d-4f4a-aa2a-d98a3d7f379a)


**After PR:**


![image](https://github.com/elastic/kibana/assets/6191849/e0f0b4a7-69f4-4eb1-b5b6-14bdfa716caf)


cc @petrklapka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees
No one assigned
Labels
8.16 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bamieh @kibana-ci @jbudz @PhilippeOberti @kibanamachine