-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Consider --kbnAppHeadersOffset
value for sticky elements and page size
#185874
[Serverless] Consider --kbnAppHeadersOffset
value for sticky elements and page size
#185874
Conversation
--kbnAppHeadersOffset
value for sticky header and page size
/ci |
--kbnAppHeadersOffset
value for sticky header and page size--kbnAppHeadersOffset
value for sticky elements and page size
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra Changes LGTM 💯
fixes 176177
relates to elastic/eui#7765
Summary
Changes the
min-block-size
to account for thekibanaProjectHeader
element, which exists only in serverless, to calculate the page size and sticky elements' top position.Stateful
sticky-header-stateful.mov
Serverless
sticky_serverless.mov
no_unnecessary_scroll.mov
return_to_top.mov
How to test
yarn es serverless --projectType=PROJECT_TYPE --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true