Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Consider --kbnAppHeadersOffset value for sticky elements and page size #185874

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Jun 10, 2024

fixes 176177
relates to elastic/eui#7765

Summary

Changes the min-block-size to account for the kibanaProjectHeader element, which exists only in serverless, to calculate the page size and sticky elements' top position.

image

Stateful

sticky-header-stateful.mov

Serverless

sticky_serverless.mov
no_unnecessary_scroll.mov
return_to_top.mov

How to test

  • Start a serverless instance
    • yarn es serverless --projectType=PROJECT_TYPE --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true
  • Start a local kibana
  • Check if the pages still work as expected

@crespocarlos crespocarlos changed the title Account for --kbnAppHeadersOffset value for sticky header and page size Account for --kbnAppHeadersOffset value for sticky header and page size Jun 10, 2024
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos marked this pull request as ready for review June 10, 2024 15:07
@crespocarlos crespocarlos requested review from a team as code owners June 10, 2024 15:07
@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 labels Jun 10, 2024
@crespocarlos crespocarlos changed the title Account for --kbnAppHeadersOffset value for sticky header and page size [Serverless] Consider --kbnAppHeadersOffset value for sticky elements and page size Jun 10, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 11, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / Fleet Endpoints Integrations inputs_with_standalone_docker_agent "before all" hook for "generate a valid config for standalone agents"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1612 1611 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +28.0B
dashboard 496.5KB 496.6KB +28.0B
enterpriseSearch 2.7MB 2.7MB +28.0B
eventAnnotationListing 295.6KB 295.6KB +28.0B
filesManagement 104.6KB 104.6KB +28.0B
graph 397.0KB 397.1KB +28.0B
home 151.8KB 151.8KB +28.0B
indexManagement 661.7KB 661.7KB +28.0B
infra 1.6MB 1.6MB -323.0B
kibanaOverview 53.5KB 53.6KB +28.0B
management 45.3KB 45.3KB +28.0B
maps 3.0MB 3.0MB +28.0B
metricsDataAccess 101.0KB 101.0KB +28.0B
ml 4.1MB 4.1MB +28.0B
observabilityShared 54.9KB 54.9KB +28.0B
osquery 1.0MB 1.0MB +28.0B
searchPlayground 166.6KB 166.6KB +28.0B
security 587.8KB 587.8KB +28.0B
securitySolution 13.6MB 13.6MB +56.0B
securitySolutionEss 39.4KB 39.5KB +28.0B
securitySolutionServerless 111.2KB 111.2KB +28.0B
spaces 175.1KB 175.1KB +28.0B
visualizations 286.0KB 286.1KB +28.0B
total +321.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 158.0KB 158.0KB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 👍

@crespocarlos crespocarlos enabled auto-merge (squash) June 11, 2024 09:55
@jennypavlova jennypavlova self-requested a review June 11, 2024 10:01
Copy link
Contributor

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra Changes LGTM 💯

@crespocarlos crespocarlos merged commit 2a53b77 into elastic:main Jun 11, 2024
21 checks passed
@crespocarlos crespocarlos deleted the 176177-fix-app-header-offset-in-serverless branch June 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Management page not positioned correctly with header in serverless
4 participants