-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Serverless] Consider
--kbnAppHeadersOffset
value for sticky elemen…
…ts and page size (#185874) fixes [176177](#176177) relates to elastic/eui#7765 ## Summary Changes the `min-block-size` to account for the `kibanaProjectHeader` element, which exists only in serverless, to calculate the page size and sticky elements' top position. <img width="1728" alt="image" src="https://github.com/elastic/kibana/assets/2767137/3b3674dc-0f3a-4671-b5e9-0b2263c2c982"> ## Stateful https://github.com/elastic/kibana/assets/2767137/2383aa9d-eee1-4aaa-94af-081f53ef84a4 ## Serverless https://github.com/elastic/kibana/assets/2767137/6830e136-cb55-4bef-8a8c-2eaf3bdc8374 https://github.com/elastic/kibana/assets/2767137/2c26014b-1572-430f-ae9c-6a4093f76422 https://github.com/elastic/kibana/assets/2767137/af6449d7-4077-4340-b5af-8a29bfae95a2 ### How to test - Start a serverless instance - `yarn es serverless --projectType=PROJECT_TYPE --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true` - Start a local kibana - Check if the pages still work as expected
- Loading branch information
1 parent
82f2c96
commit 2a53b77
Showing
7 changed files
with
9 additions
and
37 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/shared-ux/page/kibana_template/impl/src/__snapshots__/page_template.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...s/shared-ux/page/kibana_template/impl/src/__snapshots__/page_template_inner.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
x-pack/plugins/observability_solution/infra/public/hooks/use_kibana_header.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters