[ML] Convert Angular filters to formatter functions #18681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
May 1, 2018
| } else { | ||
| return numeral(value).format('0a'); | ||
| } | ||
| return abbreviateWholeNumber(value, maxDigits); |
There was a problem hiding this comment.
could this not just be return abbreviateWholeNumber ?
as in,
module.filter('abbreviateWholeNumber', function () {
return abbreviateWholeNumber;
}
💚 Build Succeeded |
This was referenced May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts three Angular filters used for formatting values in the results pages to functions, and renamed the parents directory from
filterstoformatters:An Angular filter wrapper has been retained in each file, but this will be removed once all the Angular components that use these filters have been migrated to Eui / React (see #18374).
Changes to
format_value.jsandmetric_change_description.jsalso include better handling for multi-valuedactualandtypicalvalues fromlat_longdetectors (see #18192).