[ML] Display typical values for lat_long anomalies #18715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 2, 2018
peteharverson
added a commit
that referenced
this pull request
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
lat_longto the list of function descriptions for whichtypicalvalues from record level results are displayed.Originally the decision was made not to display
typicalvalues forlat_longanomalies on the basis that it is an imprecise 'average' of locations, but it has now been agreed that it is worth showing this value alongside theactualvalue in the anomalies.Note that this change means that the list of
function_descriptionvalues for showingactualandtypicalvalues are now identical, but I think it is worth maintaining these separate lists in case other functions are added for which we want to differentiate the behaviour foractualandtypicalvalues.In addition to the changes in #18681, this fixes #18192.