Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes upgrade warning #187387

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 2, 2024

The index migration checks were broken, so we were not showing our warnings when upgrade mode is set to true

image

Also adds the warning to the ML stack management page so it is correctly displayed rather than an access denied page.

image

To test, set POST _ml/set_upgrade_mode?enabled=true

Fixes #176773

@jgowdyelastic jgowdyelastic marked this pull request as ready for review July 2, 2024 16:27
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 2, 2024 16:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2023 2022 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB +1.1KB

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 1089f57 into elastic:main Jul 3, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.16 The branch "8.16" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 187387

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 3, 2024
@szabosteve szabosteve changed the title [ML] Fixing upgrade warning [ML] Fixes upgrade warning Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:fix v8.15.0
Projects
None yet
4 participants