Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Bugfix - Show warning callout in configs tab when an error occurs #187487

Merged
merged 5 commits into from
Jul 4, 2024
Merged

[Fleet] Bugfix - Show warning callout in configs tab when an error occurs #187487

merged 5 commits into from
Jul 4, 2024

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Jul 3, 2024

Fixes #181168

Summary

Show warning callout in configs tab when an error occurs. GSCC has an issue with the template (see comment) so I'm showing a warning in a case like this, instead of sticking with the broken page.

Screenshot 2024-07-03 at 15 17 32

Checklist

@criamico criamico added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0 labels Jul 3, 2024
@criamico criamico self-assigned this Jul 3, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico marked this pull request as ready for review July 3, 2024 14:31
@criamico criamico requested a review from a team as a code owner July 3, 2024 14:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🚀

@criamico
Copy link
Contributor Author

criamico commented Jul 4, 2024

@elasticmachine merge upstream

@criamico criamico enabled auto-merge (squash) July 4, 2024 08:45
@criamico criamico merged commit ef52a4b into elastic:main Jul 4, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 4, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +446.0B

History

cc @criamico

@criamico criamico deleted the 181168_gscc_error branch July 4, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] GSCC Integration throwing error when viewing Config tab
5 participants
@criamico @obltmachine @elasticmachine @nchaulet @kibanamachine