[Log threshold] Fix showing the correct log view in the rule creation flyout #189205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:fix
backport:prev-minor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 26, 2024
… flyout (elastic#189205) Related to elastic#187291 ## Summary This PR passes the rule's logView to the Log threshold rule creation flyout. Thanks to @Kerry350 and @weltenwort for explaining how this logic works ❤️ For example, if the log view ID is passed an invalid id, like this: <img src="https://github.com/user-attachments/assets/f9d4ac74-9b16-406e-93e5-141ea82d1687" width=500 /> it will fall back to the default log view will be used, and now we show the correct log view in the rule flyout. Example setting:  |Before|After| |---|---| ||| (cherry picked from commit 9c242ac)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 26, 2024
…reation flyout (#189205) (#189299) # Backport This will backport the following commits from `main` to `8.15`: - [[Log threshold] Fix showing the correct log view in the rule creation flyout (#189205)](#189205) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-07-26T15:11:30Z","message":"[Log threshold] Fix showing the correct log view in the rule creation flyout (#189205)\n\nRelated to #187291\r\n\r\n## Summary\r\n\r\nThis PR passes the rule's logView to the Log threshold rule creation\r\nflyout. Thanks to @Kerry350 and @weltenwort for explaining how this\r\nlogic works ❤️\r\n\r\nFor example, if the log view ID is passed an invalid id, like this:\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/f9d4ac74-9b16-406e-93e5-141ea82d1687\"\r\nwidth=500 />\r\n\r\nit will fall back to the default log view will be used, and now we show\r\nthe correct log view in the rule flyout.\r\n\r\nExample setting:\r\n\r\n\r\n\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"9c242ac7736115a721c14581e8df3fe943bc9cd1","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"[Log threshold] Fix showing the correct log view in the rule creation flyout","number":189205,"url":"#189205 threshold] Fix showing the correct log view in the rule creation flyout (#189205)\n\nRelated to #187291\r\n\r\n## Summary\r\n\r\nThis PR passes the rule's logView to the Log threshold rule creation\r\nflyout. Thanks to @Kerry350 and @weltenwort for explaining how this\r\nlogic works ❤️\r\n\r\nFor example, if the log view ID is passed an invalid id, like this:\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/f9d4ac74-9b16-406e-93e5-141ea82d1687\"\r\nwidth=500 />\r\n\r\nit will fall back to the default log view will be used, and now we show\r\nthe correct log view in the rule flyout.\r\n\r\nExample setting:\r\n\r\n\r\n\n\nRelated to #187291\r\n\r\n## Summary\r\n\r\nThis PR passes the rule's logView to the Log threshold rule creation\r\nflyout. Thanks to @Kerry350 and @weltenwort for explaining how this\r\nlogic works ❤️\r\n\r\nFor example, if the log view ID is passed an invalid id, like this:\r\n\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/f9d4ac74-9b16-406e-93e5-141ea82d1687\"\r\nwidth=500 />\r\n\r\nit will fall back to the default log view will be used, and now we show\r\nthe correct log view in the rule flyout.\r\n\r\nExample setting:\r\n\r\n\r\n\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|||","sha":"9c242ac7736115a721c14581e8df3fe943bc9cd1"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #187291
Summary
This PR passes the rule's logView to the Log threshold rule creation flyout. Thanks to @Kerry350 and @weltenwort for explaining how this logic works ❤️
For example, if the log view ID is passed an invalid id, like this:
it will fall back to the default log view will be used, and now we show the correct log view in the rule flyout.
Example setting: