-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI specs for EEM APIs #190203
Add OpenAPI specs for EEM APIs #190203
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Didn't look at the specs yet, but can we verify that this is compatible with the documentation team's OAS setup so that whatever we have: |
@miltonhultgren sounds good - let's not block getting these merged though - we can follow up with the rest after. once we have the specs, the conversation with the docs team becomes easier. |
Sounds good to me, I filed https://github.com/elastic/elastic-entity-model/issues/131 |
@elasticmachine merge upstream |
x-pack/plugins/observability_solution/entity_manager/server/routes/enablement/disable.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/entity_manager/server/routes/enablement/enable.ts
Show resolved
Hide resolved
Running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/plugins/observability_solution/entity_manager/server/routes/enablement/check.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/entity_manager/server/routes/enablement/enable.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Milton Hultgren <miltonhultgren@gmail.com>
…utes/enablement/check.ts Co-authored-by: Milton Hultgren <miltonhultgren@gmail.com>
Co-authored-by: Milton Hultgren <miltonhultgren@gmail.com>
…utes/enablement/enable.ts Co-authored-by: Milton Hultgren <miltonhultgren@gmail.com>
I've had a look but couldn't find any obvious issue with the schemas. I've inspected the generate schema and everything look correctly generated so I'll log this as a follow up |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Add OpenAPI specs for EEM APIs.
This PR introduces a couple of scripts to the @kbn/entities-schema package which generate OpenAPI specs and serves them in a Swagger UI.
To test: