-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Fix small CrowdStrike connector issues #190689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomsonpl
commented
Aug 19, 2024
•
edited by kibanamachine
Loading
edited by kibanamachine
- Fixes wrong field used for token
- Changes field used to get status (based on real data)
- Improves search to find host name
/ci |
tomsonpl
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
v8.15.1
labels
Aug 19, 2024
/ci |
/ci |
/ci |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
pzl
approved these changes
Aug 19, 2024
/ci |
tomsonpl
changed the title
[EDR Workflows] Fix CrowdStrike auth issue
[EDR Workflows] Fix small CrowdStrike connector issues
Aug 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @tomsonpl |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 9524bbc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2024
… (#190746) # Backport This will backport the following commits from `main` to `8.15`: - [[EDR Workflows] Fix small CrowdStrike connector issues (#190689)](#190689) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"tomasz.ciecierski@elastic.co"},"sourceCommit":{"committedDate":"2024-08-19T21:20:36Z","message":"[EDR Workflows] Fix small CrowdStrike connector issues (#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.16.0","v8.15.1"],"title":"[EDR Workflows] Fix small CrowdStrike connector issues","number":190689,"url":"https://github.com/elastic/kibana/pull/190689","mergeCommit":{"message":"[EDR Workflows] Fix small CrowdStrike connector issues (#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190689","number":190689,"mergeCommit":{"message":"[EDR Workflows] Fix small CrowdStrike connector issues (#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.15.1
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.