-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky load discover search #19265
Conversation
💚 Build Succeeded |
Jenkins, test this - one pass, let's try another one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh doh, I didn't even think about the first implementation assuming exists was a check and not a getter. I suppose that was a poor name choice. this version LGTM!
💚 Build Succeeded |
Jenkins, test this - 2nd pass |
💚 Build Succeeded |
Jenkins, test this - 3rd pass |
💔 Build Failed |
Jenkins, test this - unrelated CI failure |
💚 Build Succeeded |
This tries to fix #19258.
We now use
retry
service to wait longer for the form (that sits in the panel) to show up.