Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky load discover search #19265

Merged
merged 1 commit into from
May 22, 2018
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented May 21, 2018

This tries to fix #19258.

We now use retry service to wait longer for the form (that sits in the panel) to show up.

@timroes timroes added test Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.4.0 labels May 21, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented May 21, 2018

Jenkins, test this - one pass, let's try another one

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh doh, I didn't even think about the first implementation assuming exists was a check and not a getter. I suppose that was a poor name choice. this version LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented May 22, 2018

Jenkins, test this - 2nd pass

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented May 22, 2018

Jenkins, test this - 3rd pass

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented May 22, 2018

Jenkins, test this - unrelated CI failure

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit f84d57a into elastic:master May 22, 2018
@timroes timroes deleted the fix-flaky-test branch May 22, 2018 11:27
timroes added a commit to timroes/kibana that referenced this pull request May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: visualize lab mode disabling does not break loading saved searches
3 participants