[console] autocomplete query dsl gaps #19318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
ycombinator
reviewed
May 23, 2018
| percolate: { | ||
| field: '', | ||
| document: {} | ||
| }, |
There was a problem hiding this comment.
I think more parameters need to be supported? https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-percolate-query.html#_parameters_10
ycombinator
reviewed
May 23, 2018
|
|
||
| const SPAN_MULTI_QUERIES = { | ||
| wildcard: { | ||
| __scope_link: '.wildcard' |
There was a problem hiding this comment.
I was expecting this construction here to give me the template for the the inner wildcard query itself, much like how it works when the wildcard query is used at the top-level, but I wasn't able to do that.
Same with the other types.
|
@ycombinator I've addressed your feedback. Good catch on the inner template thing -- that never worked but good to get it working. |
💔 Build Failed |
💔 Build Failed |
ycombinator
approved these changes
May 24, 2018
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
May 24, 2018
* adding wrapper query DSL support * adding span_multi query DSL support for autocomplete * adding field_masking_span query DSL support to autocomplete * adding percolator query DSL support to autcomplete * fixing templates with nested query types * adding missing percolate params
bmcconaghy
added a commit
that referenced
this pull request
May 24, 2018
* adding wrapper query DSL support * adding span_multi query DSL support for autocomplete * adding field_masking_span query DSL support to autocomplete * adding percolator query DSL support to autcomplete * fixing templates with nested query types * adding missing percolate params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 4 query types to autocomplete in console. Closes #19178