Fix refreshed dashboard losing time range #20858

stacey-gammon · 2018-07-16T21:12:30Z

Fixes #20827

elasticmachine · 2018-07-16T22:23:09Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-17T13:04:34Z

Failed on:

Jest Tests.packages/kbn-plugin-helpers/tasks/build.creating the build skipInstallDependencies = false installs node_modules as a part of build

and

21:39:10    │ proc  [ftr]          └- ✖ fail: "dashboard app using current data create and add embeddables add new visualization link adds a new visualization"
21:39:10    │ proc  [ftr]          │        tryForTime timeout: Error: expected 0 to sort of equal 4

The second failure showed a screenshot of the homepage. I feel like I've seen this flaky behavior before. Confirming...

jenkins, test this.

elasticmachine · 2018-07-17T14:13:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-17T14:59:56Z

Okay failed again on UI Functional Tests.test/functional/apps/dashboard/_create_and_add_embeddables·js.dashboard app using current data create and add embeddables add new visualization link adds a new visualization so that one might not be flaky but a legit failure.

other one passed so will file a flaky test issue for it (#20885)

stacey-gammon · 2018-07-17T15:19:56Z

The test is failing because after saving the visualization it's redirecting to home page. I'm pretty sure I've seen this before and it's flaky. Tests also pass locally.

Try again.

jenkins, test this

elasticmachine · 2018-07-17T17:12:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-17T19:39:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-17T20:12:10Z

I now think this might be a legit issue. was able to repro locally by running more teste before the one that failed node scripts/functional_test_runner.js --debug --grep "dashboard app using current data"

elasticmachine · 2018-07-17T21:36:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-24T15:47:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-24T17:14:31Z

Failed on UI Functional Tests.test/functional/apps/home/_home·js.homepage app Kibana takes you home clicking on console on homepage should take you to console app. I don't see any open issues for a flaky test about this. Could be legit, could be flaky. Lets find out.

jenkins, test this.

nreese · 2018-07-24T19:04:54Z

src/ui/public/timepicker/kbn_global_timepicker.js

@@ -69,6 +70,7 @@ uiModules
      require: '^kbnTopNav',
      link: ($scope, element, attributes, kbnTopNav) => {
        listenForUpdates($scope);
+        updateGlobalStateWithTime($scope);

        setTimefilterValues($scope);


Call to setTimefilterValues is no longer needed since updateGlobalStateWithTime calls setTimefilterValues

nreese · 2018-07-24T19:05:14Z

src/ui/public/timepicker/kbn_global_timepicker.js

@@ -69,6 +70,7 @@ uiModules
      require: '^kbnTopNav',
      link: ($scope, element, attributes, kbnTopNav) => {
        listenForUpdates($scope);
+        updateGlobalStateWithTime($scope);


Is this what fixed the problem?

Yep, global state wasn't initialized the first time on page load which only created a problem for dashboards stored with time. As soon as any interaction happened with the time picker, it'd update global state. Everything appeared to work correctly in the UI because that was set up correctly, it was just the URL that didn't match it.

elasticmachine · 2018-07-24T21:09:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

timroes · 2018-07-25T11:05:51Z

Jenkins, test this - seemingly unrelated navigation error

elasticmachine · 2018-07-25T12:30:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese

lgtm
code review, verified changes fixes the linked issue

nreese · 2018-07-25T12:34:59Z

fail: "homepage app Kibana takes you home clicking on console on homepage should take you to console app"
12:17:04    │ proc  [ftr]      │        Error: expected false to equal true

jenkins, test this

…the url in the new tests

stacey-gammon · 2018-07-25T14:48:17Z

This should also fix the other blocker, #20764

The problem was that if you visit a dashboard and set the time range to something, say Last 5 years, then go open a dashboard that had time stored with it, the dashboard would show the time saved with it, but the URL (which is also used for reporting) would contain the "last 5 years" time.

elasticmachine · 2018-07-25T15:13:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-25T16:30:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

timroes · 2018-07-25T16:37:57Z

Jenkins, test this - flaky test

timroes

Code looks good to me, tested on Chrome Linux. Could reproduce the issue on master, can confirm this PR fixes it.

elasticmachine · 2018-07-25T18:48:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-25T19:37:39Z

Failed on #19743 again

jenkins, test this

elasticmachine · 2018-07-25T21:15:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

LGTM

* Add test that would have caught the bug * Initialize global state with current time range * Fix issue with failing tests - need to remove added "t" parameter to the url in the new tests * remove unneccessary extra call * Fix tests that failed due to globally added time in new tests * Update home page test to not care about any state.

stacey-gammon added Feature:Dashboard Dashboard related features :Sharing v7.0.0 v6.4.0 labels Jul 16, 2018

stacey-gammon mentioned this pull request Jul 17, 2018

Flaky test: Jest Tests.packages/kbn-plugin-helpers/tasks/build.creating the build skipInstallDependencies = false installs node_modules as a part of build #20885

Closed

stacey-gammon changed the title ~~Fix refreshed dashboard losing time range~~ [WIP] Fix refreshed dashboard losing time range Jul 17, 2018

stacey-gammon force-pushed the 2018-07-16-global-time-bug branch from cc58e3b to 2a21616 Compare July 17, 2018 16:00

stacey-gammon force-pushed the 2018-07-16-global-time-bug branch from 1d715e9 to f467014 Compare July 17, 2018 20:26

stacey-gammon force-pushed the 2018-07-16-global-time-bug branch from f467014 to bb12fc6 Compare July 24, 2018 13:34

stacey-gammon changed the title ~~[WIP] Fix refreshed dashboard losing time range~~ Fix refreshed dashboard losing time range Jul 24, 2018

stacey-gammon requested review from nreese and ppisljar July 24, 2018 18:38

nreese reviewed Jul 24, 2018

View reviewed changes

stacey-gammon mentioned this pull request Jul 25, 2018

Flaky Test: homepage app Kibana takes you home clicking on console on homepage should take you to console app #21199

Closed

nreese approved these changes Jul 25, 2018

View reviewed changes

stacey-gammon added 4 commits July 25, 2018 10:09

Fix issue with failing tests - need to remove added "t" parameter to …

302b9a1

…the url in the new tests

remove unneccessary extra call

3bbb25f

Fix tests that failed due to globally added time in new tests

6fcd4b1

Update home page test to not care about any state.

65b28fb

stacey-gammon force-pushed the 2018-07-16-global-time-bug branch from 0061438 to 65b28fb Compare July 25, 2018 14:43

stacey-gammon requested a review from timroes July 25, 2018 15:41

stacey-gammon mentioned this pull request Jul 25, 2018

Fix and re-enable Visualize lab mode test #19743

Closed

timroes approved these changes Jul 25, 2018

View reviewed changes

LeeDr added v6.5.0 and removed v6.5.0 v6.4.0 labels Jul 25, 2018

ppisljar approved these changes Jul 26, 2018

View reviewed changes

stacey-gammon merged commit 38dcda0 into elastic:master Jul 26, 2018

stacey-gammon mentioned this pull request Jul 26, 2018

[6.x] Fix refreshed dashboard losing time range (#20858) #21264

Merged

stacey-gammon mentioned this pull request Jul 26, 2018

[6.4] Fix refreshed dashboard losing time range (#20858) #21267

Merged

stacey-gammon mentioned this pull request Jul 26, 2018

Reports did not match the dashboard #20764

Closed

This was referenced Jul 27, 2018

Global time range in URL overwritten in certain situations. #21326

Closed

Page refresh on Dashboard with saved time loses time range #20827

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix refreshed dashboard losing time range #20858

Fix refreshed dashboard losing time range #20858

stacey-gammon commented Jul 16, 2018 •

edited by timroes

Loading

elasticmachine commented Jul 16, 2018

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

elasticmachine commented Jul 24, 2018

stacey-gammon commented Jul 24, 2018

nreese Jul 24, 2018

nreese Jul 24, 2018

stacey-gammon Jul 25, 2018

elasticmachine commented Jul 24, 2018

timroes commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

nreese left a comment

nreese commented Jul 25, 2018

stacey-gammon commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

timroes commented Jul 25, 2018

timroes left a comment

elasticmachine commented Jul 25, 2018

stacey-gammon commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

ppisljar left a comment

Fix refreshed dashboard losing time range #20858

Fix refreshed dashboard losing time range #20858

Conversation

stacey-gammon commented Jul 16, 2018 • edited by timroes Loading

elasticmachine commented Jul 16, 2018

💔 Build Failed

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

💔 Build Failed

stacey-gammon commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

💔 Build Failed

elasticmachine commented Jul 17, 2018

💔 Build Failed

stacey-gammon commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

💔 Build Failed

elasticmachine commented Jul 24, 2018

💔 Build Failed

stacey-gammon commented Jul 24, 2018

nreese Jul 24, 2018

Choose a reason for hiding this comment

nreese Jul 24, 2018

Choose a reason for hiding this comment

stacey-gammon Jul 25, 2018

Choose a reason for hiding this comment

elasticmachine commented Jul 24, 2018

💔 Build Failed

timroes commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

💔 Build Failed

nreese left a comment

Choose a reason for hiding this comment

nreese commented Jul 25, 2018

stacey-gammon commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

💚 Build Succeeded

elasticmachine commented Jul 25, 2018

💔 Build Failed

timroes commented Jul 25, 2018

timroes left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 25, 2018

💔 Build Failed

stacey-gammon commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

💚 Build Succeeded

ppisljar left a comment

Choose a reason for hiding this comment

stacey-gammon commented Jul 16, 2018 •

edited by timroes

Loading