[fetch] polyfill globally like all others #20963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2018
As @sqren mentioned in elastic#20914 (comment) we are using three different fetch polyfills, and it's not totally clear which one is winning out. For some time `import 'whatwg-fetch'` has been included globally in the browser for the last 6 months or so, but wasn't compatible with jest tests running in node.js, which seems to be the reason people have been reaching for `isomorphic-fetch`. Rather than relying on the version of `whatwg-fetch` and `node-fetch` that `isomorphic-fetch` depends on, we can just rely on them directly and stub out the global fetch for jest tests in a jest setup module.
💔 Build Failed |
|
Looks like |
|
Yeah, I tried looking into it but it's unclear why the tests were passing before but not now. thinking it might be because of how old the node-fetch inside isomorphic-fetch was... but haven't spent time to really look into it |
|
Hey @spalger , I'm removing review request from myself just to keep things on my Dashboard tidy, but feel free to request it once again if you still need one :) |
|
Might come back to this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @sqren mentioned in #20914 (comment) we are using three different fetch polyfills, and it's not totally clear which one is winning out. For some time
import 'whatwg-fetch'has been included globally in the browser for the last 6 months or so, but wasn't compatible with jest tests running in node.js, which seems to be the reason people have been reaching forisomorphic-fetch. Rather than relying on the version ofwhatwg-fetchandnode-fetchthatisomorphic-fetchdepends on, we can just rely on them directly and stub out the global fetch for jest tests in a jest setup module.